From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] PowerPC: usb ehci of_platform bindings for Sequoia 440EPx
Date: Fri, 14 Sep 2007 18:31:32 +0400 [thread overview]
Message-ID: <46EA9B44.6030606@ru.mvista.com> (raw)
In-Reply-To: <2c5fb8f063c275286b6b26ca734ed64d@kernel.crashing.org>
Segher Boessenkool wrote:
>> EHCI OF bindings for PowerPC 440EPx Sequoia.
>
> Those aren't bindings, they are examples. Bindings are pieces
> of documentation that describe what device-specific properties
> mean what, what standard properties are required with what
> values, etc.
>
> Examples are good to have, of course.
>
> One thing you really need to document is what "ehci-be-desc"
> and friends mean. I can give you one comment already: for
> devices that are usually little-endian, but an implementation
> implements registers as big-endian, precedent is to show that
> in the device tree by including an (empty) "big-endian" property,
> rather than inventing new "compatible" values.
I was looking at the ohci-ppc-of driver that has "ohci-bigendian"
compatible string and enables both be-mmio and be-desc for the device in
this case. I just wanted to separate mmio and desc stuff for ehci, since
some devices need be-mmio only.
I'll use "big-endian" property instead of "ehci-be-mmio" compatible
value. That's a good point, thanks.
Do I have to add "sequoia usb ehci" description to
Documentation/powerpc/booting-without-of.txt?
Do I also have to describe ehci-ppc-of stuff in general?
BTW, I see nothing about ohci-ppc-of there.
Thanks,
Valentine.
>
>
> Segher
>
next prev parent reply other threads:[~2007-09-14 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 17:57 [PATCH] usb: add support for device tree aware EHCI driver Valentine Barshak
2007-09-13 18:18 ` Josh Boyer
2007-09-13 18:24 ` [PATCH] PowerPC: usb ehci of_platform bindings for Sequoia 440EPx Valentine Barshak
2007-09-13 22:36 ` Segher Boessenkool
2007-09-14 14:31 ` Valentine Barshak [this message]
2007-09-14 15:35 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EA9B44.6030606@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox