From: Segher Boessenkool <segher@kernel•crashing.org>
To: Valentine Barshak <vbarshak@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] PowerPC: usb ehci of_platform bindings for Sequoia 440EPx
Date: Fri, 14 Sep 2007 00:36:53 +0200 [thread overview]
Message-ID: <2c5fb8f063c275286b6b26ca734ed64d@kernel.crashing.org> (raw)
In-Reply-To: <20070913182453.GA26541@ru.mvista.com>
> EHCI OF bindings for PowerPC 440EPx Sequoia.
Those aren't bindings, they are examples. Bindings are pieces
of documentation that describe what device-specific properties
mean what, what standard properties are required with what
values, etc.
Examples are good to have, of course.
One thing you really need to document is what "ehci-be-desc"
and friends mean. I can give you one comment already: for
devices that are usually little-endian, but an implementation
implements registers as big-endian, precedent is to show that
in the device tree by including an (empty) "big-endian" property,
rather than inventing new "compatible" values.
Segher
next prev parent reply other threads:[~2007-09-13 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 17:57 [PATCH] usb: add support for device tree aware EHCI driver Valentine Barshak
2007-09-13 18:18 ` Josh Boyer
2007-09-13 18:24 ` [PATCH] PowerPC: usb ehci of_platform bindings for Sequoia 440EPx Valentine Barshak
2007-09-13 22:36 ` Segher Boessenkool [this message]
2007-09-14 14:31 ` Valentine Barshak
2007-09-14 15:35 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5fb8f063c275286b6b26ca734ed64d@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=vbarshak@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox