From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org, linux-usb-devel@lists•sourceforge.net
Subject: Re: [PATCH 1/3] usb: add device-tree-aware ehci driver
Date: Mon, 17 Sep 2007 22:17:15 +0400 [thread overview]
Message-ID: <46EEC4AB.2030707@ru.mvista.com> (raw)
In-Reply-To: <20070917232809.1221acd9.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> On Mon, 17 Sep 2007 16:55:43 +0400 Valentine Barshak <vbarshak@ru•mvista.com> wrote:
>> +++ linux-2.6/drivers/usb/host/ehci-ppc-of.c 2007-09-15 16:12:56.000000000 +0400
>> @@ -0,0 +1,220 @@
>> +
>> +#include <asm/of_platform.h>
>> +#include <asm/prom.h>
>
> Please use linux/of.h and linux/of_platform.h instead.
>
>> +static int ehci_hcd_ppc_of_shutdown(struct of_device *op)
>> +{
>> + struct usb_hcd *hcd = dev_get_drvdata(&op->dev);
>> +
>> + if (hcd->driver->shutdown)
>> + hcd->driver->shutdown(hcd);
>
> White space has gone a bit funny here.
>
Corrected...
Sending new patch in a minute.
Looks like we'll need a patch that replaces asm/prom.h and
asm/of_platform.h with linux/of.h and linux/of_platform.h
in other drivers.
ohci-ppc-of is definitely gonna need it.
BTW, I think the ohci_hcd_ppc_of_match stuff for ohci-ppc-of.c has to be
modified.
I think it should be .type="usb" instead of .name="usb" and
.compatible="ohci-littlendian" doesn't look good to me either.
Thanks,
Valentine.
next prev parent reply other threads:[~2007-09-17 18:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 12:50 [PATCH 0/3] usb: ehci ppc device-tree-aware driver Valentine Barshak
2007-09-17 12:55 ` [PATCH 1/3] usb: add device-tree-aware ehci driver Valentine Barshak
2007-09-17 13:00 ` [PATCH 2/3] usb: ehci-ppc-of dts bindings Valentine Barshak
2007-09-19 0:25 ` Segher Boessenkool
2007-09-19 13:52 ` Valentine Barshak
2007-09-19 16:50 ` Segher Boessenkool
2007-09-19 16:55 ` Valentine Barshak
2007-09-24 19:32 ` [linux-usb-devel] " Valentine Barshak
2007-09-20 0:52 ` David Gibson
2007-09-24 21:40 ` Segher Boessenkool
2007-09-17 13:28 ` [PATCH 1/3] usb: add device-tree-aware ehci driver Stephen Rothwell
2007-09-17 14:00 ` Josh Boyer
2007-09-17 18:17 ` Valentine Barshak [this message]
2007-09-18 4:26 ` Stephen Rothwell
2007-09-18 5:39 ` David Gibson
2007-09-17 18:18 ` Valentine Barshak
2007-09-17 13:02 ` [PATCH 3/3] Add PowerPC 440EPx Sequoia ehci dts entry Valentine Barshak
2007-09-22 23:00 ` [PATCH 0/3] usb: ehci ppc device-tree-aware driver Hollis Blanchard
2007-09-24 10:33 ` Valentine Barshak
2007-10-08 18:15 ` Jerone Young
2007-10-08 18:18 ` Valentine Barshak
2007-10-08 18:22 ` Valentine Barshak
-- strict thread matches above, loose matches on Subject: below --
2007-09-24 19:25 Valentine Barshak
2007-09-24 19:26 ` [PATCH 1/3] usb: add device-tree-aware ehci driver Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EEC4AB.2030707@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=linux-usb-devel@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox