From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Dale Farnsworth <dale@farnsworth•org>
Cc: Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry
Date: Wed, 24 Oct 2007 15:19:14 +0400 [thread overview]
Message-ID: <471F2A32.8030202@ru.mvista.com> (raw)
In-Reply-To: <20071023214000.424.qmail@farnsworth.org>
Dale Farnsworth wrote:
> Valentine wrote:
>> Actually I also don't see much reason for the
>> USB_OHCI_HCD_PPC_OF_BE/USB_OHCI_HCD_PPC_OF_LE stuff.
>> Is this really needed?
>
> I think so. The SOC host controllers are BE and the PCI
> host controllers are LE. Or, do you have an alternative
> method of handling both types?
>
> -Dale
Yes, PCI controllers are LE, but do we really need user-selectable
USB_OHCI_HCD_PPC_OF_LE option, since USB_OHCI_LITTLE_ENDIAN is selected
by default for USB_OHCI_HCD_PCI?
The USB_OHCI_HCD_PPC_OF_LE/BE stuff is related to PPC OF glue only.
I think it's useless. We should always enable
USB_OHCI_BIG_ENDIAN_DESC and USB_OHCI_BIG_ENDIAN_MMIO for PPC OF
and the real LE/BE implementation should be selected by the
corresponding properties in the device tree.
Thanks,
Valentine.
next prev parent reply other threads:[~2007-10-24 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 14:26 [PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry Valentine Barshak
2007-10-23 15:33 ` Josh Boyer
2007-10-23 15:35 ` Valentine Barshak
2007-10-23 15:50 ` Josh Boyer
2007-10-23 17:03 ` Segher Boessenkool
2007-10-23 17:18 ` Valentine Barshak
2007-10-23 21:40 ` Dale Farnsworth
2007-10-24 11:19 ` Valentine Barshak [this message]
2007-10-24 12:08 ` Dale Farnsworth
2007-10-24 13:44 ` Valentine Barshak
2007-10-24 14:10 ` Dale Farnsworth
2007-10-24 14:23 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F2A32.8030202@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=dale@farnsworth$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox