* Missing patch for MPC5200B register definitions?
@ 2008-03-26 16:15 Matt Sealey
2008-03-26 16:48 ` Matt Sealey
2008-03-27 13:27 ` Grant Likely
0 siblings, 2 replies; 5+ messages in thread
From: Matt Sealey @ 2008-03-26 16:15 UTC (permalink / raw)
To: ppc-dev
I've just been looking into the MPC5200B AC97 driver breakage with the
latest Git kernel, and found the following patch;
http://ozlabs.org/pipermail/linuxppc-dev/2007-May/035952.html
Is not in the latest tree. As such anything which uses the new MPC5200B
registers (especially important on AC97 and probably not used otherwise)
has not or was not applied.
Since the latest kernel source from git actually includes the MPC5121E
differences, I assume this is a regression?
How do we go about fixing this?
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing patch for MPC5200B register definitions?
2008-03-26 16:15 Missing patch for MPC5200B register definitions? Matt Sealey
@ 2008-03-26 16:48 ` Matt Sealey
2008-03-27 13:25 ` Grant Likely
2008-03-27 13:27 ` Grant Likely
1 sibling, 1 reply; 5+ messages in thread
From: Matt Sealey @ 2008-03-26 16:48 UTC (permalink / raw)
To: ppc-dev
Oh yes, I forgot.. also, the new MPC5121E stuff includes a lot of unions and
defines to make using both PSC formats easier.
Since the MPC5200 and MPC5200B PSC structures are different (CCR size), can the
original suggestion (in that thread) to support both with a union and some
defines to make supporting both CCR sizes, be implemented, or do we still think
that MPC5200 (not B) is not worth supporting?
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
Matt Sealey wrote:
> I've just been looking into the MPC5200B AC97 driver breakage with the
> latest Git kernel, and found the following patch;
>
> http://ozlabs.org/pipermail/linuxppc-dev/2007-May/035952.html
>
> Is not in the latest tree. As such anything which uses the new MPC5200B
> registers (especially important on AC97 and probably not used otherwise)
> has not or was not applied.
>
> Since the latest kernel source from git actually includes the MPC5121E
> differences, I assume this is a regression?
>
> How do we go about fixing this?
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing patch for MPC5200B register definitions?
2008-03-26 16:48 ` Matt Sealey
@ 2008-03-27 13:25 ` Grant Likely
0 siblings, 0 replies; 5+ messages in thread
From: Grant Likely @ 2008-03-27 13:25 UTC (permalink / raw)
To: Matt Sealey; +Cc: ppc-dev
On Wed, Mar 26, 2008 at 10:48 AM, Matt Sealey <matt@genesi-usa•com> wrote:
> Oh yes, I forgot.. also, the new MPC5121E stuff includes a lot of unions and
> defines to make using both PSC formats easier.
>
> Since the MPC5200 and MPC5200B PSC structures are different (CCR size), can the
> original suggestion (in that thread) to support both with a union and some
> defines to make supporting both CCR sizes, be implemented, or do we still think
> that MPC5200 (not B) is not worth supporting?
Until someone writes a driver actually using it; let's pretend it
doesn't exist. :-) It's not too difficult to add it back in at a
later date if someone does decide to support it.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing patch for MPC5200B register definitions?
2008-03-26 16:15 Missing patch for MPC5200B register definitions? Matt Sealey
2008-03-26 16:48 ` Matt Sealey
@ 2008-03-27 13:27 ` Grant Likely
2008-03-28 12:36 ` Matt Sealey
1 sibling, 1 reply; 5+ messages in thread
From: Grant Likely @ 2008-03-27 13:27 UTC (permalink / raw)
To: Matt Sealey; +Cc: ppc-dev
On Wed, Mar 26, 2008 at 10:15 AM, Matt Sealey <matt@genesi-usa•com> wrote:
> I've just been looking into the MPC5200B AC97 driver breakage with the
> latest Git kernel, and found the following patch;
>
> http://ozlabs.org/pipermail/linuxppc-dev/2007-May/035952.html
>
> Is not in the latest tree. As such anything which uses the new MPC5200B
> registers (especially important on AC97 and probably not used otherwise)
> has not or was not applied.
>
> Since the latest kernel source from git actually includes the MPC5121E
> differences, I assume this is a regression?
>
> How do we go about fixing this?
Write a patch to apply that change in arch/powerpc and post it to the
list. If it looks good, I'll pick it up.
BTW, did you figure out if the AC97 driver is being picked up by the
ALSA maintainers?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing patch for MPC5200B register definitions?
2008-03-27 13:27 ` Grant Likely
@ 2008-03-28 12:36 ` Matt Sealey
0 siblings, 0 replies; 5+ messages in thread
From: Matt Sealey @ 2008-03-28 12:36 UTC (permalink / raw)
To: Grant Likely; +Cc: ppc-dev
Grant Likely wrote:
> On Wed, Mar 26, 2008 at 10:15 AM, Matt Sealey <matt@genesi-usa•com> wrote:
>> I've just been looking into the MPC5200B AC97 driver breakage with the
>> latest Git kernel, and found the following patch;
>>
>> http://ozlabs.org/pipermail/linuxppc-dev/2007-May/035952.html
>>
>> Is not in the latest tree. As such anything which uses the new MPC5200B
>> registers (especially important on AC97 and probably not used otherwise)
>> has not or was not applied.
>>
>> Since the latest kernel source from git actually includes the MPC5121E
>> differences, I assume this is a regression?
>>
>> How do we go about fixing this?
>
> Write a patch to apply that change in arch/powerpc and post it to the
> list. If it looks good, I'll pick it up.
I'll make one now. The AC97 driver needs it anyway, later, plus some
definitions are missing for PSC control.. also only used by the AC97
driver for now, but still probably quite important (or just hardcoded
elsewhere).
> BTW, did you figure out if the AC97 driver is being picked up by the
> ALSA maintainers?
We just worked around a crash bug (somehow..) but now we get no audio.
I'm not going to submit it to them until we can actually get sound
out of the damn thing..
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-03-28 12:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-26 16:15 Missing patch for MPC5200B register definitions? Matt Sealey
2008-03-26 16:48 ` Matt Sealey
2008-03-27 13:25 ` Grant Likely
2008-03-27 13:27 ` Grant Likely
2008-03-28 12:36 ` Matt Sealey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox