From: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, Kumar Gala <kumar.gala@freescale•com>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] Add kernstart_addr to list of allowed symbols in prom_init
Date: Wed, 21 May 2008 12:21:13 +0530 [thread overview]
Message-ID: <4833C661.2040800@linux.vnet.ibm.com> (raw)
In-Reply-To: <f4219729e8da75f5176347d176430d4b8b0fcb8a.1211287582.git.michael@ellerman.id.au>
Michael Ellerman wrote:
> Since commit "85xx: Add support for relocatable kernel (and
> booting at non-zero)" (37dd2badcfcec35f5e21a0926968d77a404f03c3),
> PHYSICAL_START is #defined as kernstart_addr if RELOCATABLE
> and FLATMEM is enabled.
>
> PHYSICAL_START is used in prom_init.c and so kernstart_addr
> needs to be added to the list of allowed symbols that
> prom_init.c can access.
>
> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
> ---
>
> Not sure if anyone is building this config in practice, but it
> is broken in 26 without this patch.
>
> arch/powerpc/kernel/prom_init_check.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
> index 8e24fc1..31729a9 100644
> --- a/arch/powerpc/kernel/prom_init_check.sh
> +++ b/arch/powerpc/kernel/prom_init_check.sh
> @@ -20,7 +20,7 @@ WHITELIST="add_reloc_offset __bss_start __bss_stop copy_and_flush
> _end enter_prom memcpy memset reloc_offset __secondary_hold
> __secondary_hold_acknowledge __secondary_hold_spinloop __start
> strcmp strcpy strlcpy strlen strncmp strstr logo_linux_clut224
> -reloc_got2"
> +reloc_got2 kernstart_addr"
>
> NM="$1"
> OBJ="$2"
Hi Michael,
Thanks, the patch fixes the build failure.
Tested-by: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
prev parent reply other threads:[~2008-05-21 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 12:48 [PATCH] Add kernstart_addr to list of allowed symbols in prom_init Michael Ellerman
2008-05-20 13:08 ` Kumar Gala
2008-05-21 6:51 ` Kamalesh Babulal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833C661.2040800@linux.vnet.ibm.com \
--to=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox