* [PATCH] Add kernstart_addr to list of allowed symbols in prom_init
@ 2008-05-20 12:48 Michael Ellerman
2008-05-20 13:08 ` Kumar Gala
2008-05-21 6:51 ` Kamalesh Babulal
0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2008-05-20 12:48 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev, Kumar Gala, kamalesh
Since commit "85xx: Add support for relocatable kernel (and
booting at non-zero)" (37dd2badcfcec35f5e21a0926968d77a404f03c3),
PHYSICAL_START is #defined as kernstart_addr if RELOCATABLE
and FLATMEM is enabled.
PHYSICAL_START is used in prom_init.c and so kernstart_addr
needs to be added to the list of allowed symbols that
prom_init.c can access.
Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
---
Not sure if anyone is building this config in practice, but it
is broken in 26 without this patch.
arch/powerpc/kernel/prom_init_check.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index 8e24fc1..31729a9 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -20,7 +20,7 @@ WHITELIST="add_reloc_offset __bss_start __bss_stop copy_and_flush
_end enter_prom memcpy memset reloc_offset __secondary_hold
__secondary_hold_acknowledge __secondary_hold_spinloop __start
strcmp strcpy strlcpy strlen strncmp strstr logo_linux_clut224
-reloc_got2"
+reloc_got2 kernstart_addr"
NM="$1"
OBJ="$2"
--
1.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add kernstart_addr to list of allowed symbols in prom_init
2008-05-20 12:48 [PATCH] Add kernstart_addr to list of allowed symbols in prom_init Michael Ellerman
@ 2008-05-20 13:08 ` Kumar Gala
2008-05-21 6:51 ` Kamalesh Babulal
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2008-05-20 13:08 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Paul Mackerras, kamalesh
On May 20, 2008, at 7:48 AM, Michael Ellerman wrote:
> Since commit "85xx: Add support for relocatable kernel (and
> booting at non-zero)" (37dd2badcfcec35f5e21a0926968d77a404f03c3),
> PHYSICAL_START is #defined as kernstart_addr if RELOCATABLE
> and FLATMEM is enabled.
>
> PHYSICAL_START is used in prom_init.c and so kernstart_addr
> needs to be added to the list of allowed symbols that
> prom_init.c can access.
>
> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
Acked-by: Kumar Gala <galak@kernel•crashing.org>
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add kernstart_addr to list of allowed symbols in prom_init
2008-05-20 12:48 [PATCH] Add kernstart_addr to list of allowed symbols in prom_init Michael Ellerman
2008-05-20 13:08 ` Kumar Gala
@ 2008-05-21 6:51 ` Kamalesh Babulal
1 sibling, 0 replies; 3+ messages in thread
From: Kamalesh Babulal @ 2008-05-21 6:51 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Kumar Gala, Paul Mackerras
Michael Ellerman wrote:
> Since commit "85xx: Add support for relocatable kernel (and
> booting at non-zero)" (37dd2badcfcec35f5e21a0926968d77a404f03c3),
> PHYSICAL_START is #defined as kernstart_addr if RELOCATABLE
> and FLATMEM is enabled.
>
> PHYSICAL_START is used in prom_init.c and so kernstart_addr
> needs to be added to the list of allowed symbols that
> prom_init.c can access.
>
> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
> ---
>
> Not sure if anyone is building this config in practice, but it
> is broken in 26 without this patch.
>
> arch/powerpc/kernel/prom_init_check.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
> index 8e24fc1..31729a9 100644
> --- a/arch/powerpc/kernel/prom_init_check.sh
> +++ b/arch/powerpc/kernel/prom_init_check.sh
> @@ -20,7 +20,7 @@ WHITELIST="add_reloc_offset __bss_start __bss_stop copy_and_flush
> _end enter_prom memcpy memset reloc_offset __secondary_hold
> __secondary_hold_acknowledge __secondary_hold_spinloop __start
> strcmp strcpy strlcpy strlen strncmp strstr logo_linux_clut224
> -reloc_got2"
> +reloc_got2 kernstart_addr"
>
> NM="$1"
> OBJ="$2"
Hi Michael,
Thanks, the patch fixes the build failure.
Tested-by: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-21 6:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-20 12:48 [PATCH] Add kernstart_addr to list of allowed symbols in prom_init Michael Ellerman
2008-05-20 13:08 ` Kumar Gala
2008-05-21 6:51 ` Kamalesh Babulal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox