public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Matt Sealey <matt@genesi-usa•com>
To: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: PowerPC USB controller support - ohci-ppc-of.c and ohci-ppc-soc.c
Date: Thu, 30 Oct 2008 12:53:22 -0500	[thread overview]
Message-ID: <4909F492.3080401@genesi-usa.com> (raw)

Hi guys,

I'm curious as to the difference between ohci-ppc-of.c and
ohci-ppc-soc.c in drivers/usb/host - the way I am looking at
this, ohci-ppc-soc.c is completely redundant now as no
arch/powerpc platform should be using this method of registering
a platform device, and therefore it's a legacy from arch/ppc
that should go away like CONFIG_PPC_MERGE did?

Can anyone confirm this?

I also noticed a very strange Kconfig dependency when checking
through this stuff with Grant (so I could see what to remove if
I got rid of ohci-ppc-soc.c, the config for USB_OHCI_HCD_PPC_SOC
would disappear;

config USB_OHCI_HCD_PCI
          bool "OHCI support for PCI-bus USB controllers"
          depends on USB_OHCI_HCD && PCI && (STB03xxx || PPC_MPC52xx || USB_OHCI_HCD_PPC_OF)
          default y
          select USB_OHCI_LITTLE_ENDIAN
          ---help---
            Enables support for PCI-bus plug-in USB controller cards.
            If unsure, say Y.

I am really curious as to why OHCI for PCI bus depends on STB03xxx
or MPC52xx? Couldn't these be removed? I am guessing USB_OHCI_HCD_PPC_OF
is specifically required here because it sets up the support from the
device tree if it's present (although aren't PCI devices detected and
utilized some other way? Is this a concession to having internal AND
PCI controllers of the same type?) but I do not understand the
dependency on those two chips, specifically, in this day and age.

I'll roll up a patch along with a couple other things tomorrow or the
weekend based on what I hear here..

-- 
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations

                 reply	other threads:[~2008-10-30 17:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4909F492.3080401@genesi-usa.com \
    --to=matt@genesi-usa$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox