* PowerPC USB controller support - ohci-ppc-of.c and ohci-ppc-soc.c
@ 2008-10-30 17:53 Matt Sealey
0 siblings, 0 replies; only message in thread
From: Matt Sealey @ 2008-10-30 17:53 UTC (permalink / raw)
To: linuxppc-dev list
Hi guys,
I'm curious as to the difference between ohci-ppc-of.c and
ohci-ppc-soc.c in drivers/usb/host - the way I am looking at
this, ohci-ppc-soc.c is completely redundant now as no
arch/powerpc platform should be using this method of registering
a platform device, and therefore it's a legacy from arch/ppc
that should go away like CONFIG_PPC_MERGE did?
Can anyone confirm this?
I also noticed a very strange Kconfig dependency when checking
through this stuff with Grant (so I could see what to remove if
I got rid of ohci-ppc-soc.c, the config for USB_OHCI_HCD_PPC_SOC
would disappear;
config USB_OHCI_HCD_PCI
bool "OHCI support for PCI-bus USB controllers"
depends on USB_OHCI_HCD && PCI && (STB03xxx || PPC_MPC52xx || USB_OHCI_HCD_PPC_OF)
default y
select USB_OHCI_LITTLE_ENDIAN
---help---
Enables support for PCI-bus plug-in USB controller cards.
If unsure, say Y.
I am really curious as to why OHCI for PCI bus depends on STB03xxx
or MPC52xx? Couldn't these be removed? I am guessing USB_OHCI_HCD_PPC_OF
is specifically required here because it sets up the support from the
device tree if it's present (although aren't PCI devices detected and
utilized some other way? Is this a concession to having internal AND
PCI controllers of the same type?) but I do not understand the
dependency on those two chips, specifically, in this day and age.
I'll roll up a patch along with a couple other things tomorrow or the
weekend based on what I hear here..
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-30 17:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-30 17:53 PowerPC USB controller support - ohci-ppc-of.c and ohci-ppc-soc.c Matt Sealey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox