From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] ps3: ps3-lpm.c compile fix
Date: Mon, 3 Nov 2008 11:03:13 -0800 [thread overview]
Message-ID: <490F4AF1.4060902@am.sony.com> (raw)
In-Reply-To: <20081103134829.GA3432@x200.localdomain>
Alexey Dobriyan wrote:
> On Mon, Nov 03, 2008 at 09:20:28AM +0100, Geert Uytterhoeven wrote:
>> On Sun, 2 Nov 2008, Alexey Dobriyan wrote:
>> > drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id'
>> >
>> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail•com>
Acked-by: Geoff Levand <geoffrey.levand@am•sony.com>
>> > --- a/drivers/ps3/ps3-lpm.c
>> > +++ b/drivers/ps3/ps3-lpm.c
>> > @@ -22,6 +22,7 @@
>> > #include <linux/module.h>
>> > #include <linux/interrupt.h>
>> > #include <linux/uaccess.h>
>> > +#include <asm/smp.h>
>>
>> #include <linux/smp.h>?
>
> Nope, everybody else uses asm/smp.h.
That doesn't quite seem like enough reason for me.
Looking at the source, I see linux/smp.h only includes
asm/smp.h when CONFIG_SMP=y, so we at least need to
include asm/smp.h to get the get_hard_smp_processor_id
def when CONFIG_SMP=n.
-Geoff
prev parent reply other threads:[~2008-11-03 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 17:26 [PATCH] ps3: ps3-lpm.c compile fix Alexey Dobriyan
2008-11-03 8:20 ` Geert Uytterhoeven
2008-11-03 13:48 ` Alexey Dobriyan
2008-11-03 19:03 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490F4AF1.4060902@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox