From: Heiko Schocher <hs@denx•de>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] 83xx: add support for the kmeter1 board.
Date: Thu, 23 Apr 2009 16:50:11 +0200 [thread overview]
Message-ID: <49F08023.4060607@denx.de> (raw)
In-Reply-To: <6B76A454-649E-408C-A8DF-AAEEE6011929@kernel.crashing.org>
Hello Kumar,
Kumar Gala wrote:
>> diff --git a/arch/powerpc/boot/dts/kmeter1.dts
>> b/arch/powerpc/boot/dts/kmeter1.dts
>> new file mode 100644
>> index 0000000..4f343ca
>> --- /dev/null
>> +++ b/arch/powerpc/boot/dts/kmeter1.dts
>> @@ -0,0 +1,518 @@
>> +/*
>> + * Keymile KMETER1 Device Tree Source
>> + *
[...]
>> +
>> +
>> +/*
>> +/memreserve/ 00000000 1000000;
>> +*/
>
> is this needed for something?
No, I delete it.
>>
>> +
>> +/dts-v1/;
>> +
>> +/ {
>> + model = "KMETER1";
[...]
>> +
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + PowerPC,8360@0 {
>> + device_type = "cpu";
>> + reg = <0x0>;
>> + d-cache-line-size = <32>; // 32 bytes
>> + i-cache-line-size = <32>; // 32 bytes
>> + d-cache-size = <32768>; // L1, 32K
>> + i-cache-size = <32768>; // L1, 32K
>> + timebase-frequency = <66000000>;
>> + bus-frequency = <264000000>;
>> + clock-frequency = <528000000>;
>
> is the board running at a fixed frequency that isn't possible to change?
No, u-boot updates this. I fix this.
>> + };
>> + };
>> +
>> + memory {
>> + device_type = "memory";
>> + reg = <0x00000000 0x10000000>;
>> + };
>
> does u-boot not set this? Also is the amount of memory fixed?
No, u-boot updates this. I fix this too. (and all other places)
>> +
>> + soc8360@e0000000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "soc";
>> + compatible = "simple-bus";
[...]
>> + };
>> + };
>> +
>> + qe@e0100000 {
>
> why isn't this under the SOC?
No reason for that, you are right, I fix this too.
>>
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "qe";
>> + compatible = "fsl,qe";
>> + ranges = <0x0 0xe0100000 0x00100000>;
>> + reg = <0xe0100000 0x480>;
>> + brg-frequency = <0>;
>> + bus-frequency = <396000000>;
>> +
[...]
>> +
>> + qeic: interrupt-controller@80 {
>> + interrupt-controller;
>> + compatible = "fsl,qe-ic";
>> + #address-cells = <0>;
>> + #interrupt-cells = <1>;
>> + reg = <0x80 0x80>;
>> + big-endian;
>
> seems unnecessary .. the qe is only big-endian.
OK.
>> + interrupts = <32 8 33 8>;
>> + interrupt-parent = <&ipic>;
>> + };
>> + };
>
>
>> diff --git a/arch/powerpc/platforms/83xx/kmeter1.c
>> b/arch/powerpc/platforms/83xx/kmeter1.c
>> new file mode 100644
>> index 0000000..99cf5c6
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/83xx/kmeter1.c
>> @@ -0,0 +1,170 @@
>> +/*
>> + * Copyright 2008 DENX Software Engineering GmbH
>> + * Author: Heiko Schocher <hs@denx•de>
[...]
>> +
>> + np = of_find_compatible_node(NULL, "network", "ucc_geth");
>> + if (np != NULL) {
>> + uint svid;
>> +
>> + /* handle mpc8360ea rev.2.1 erratum 2: RGMII Timing */
>> + svid = mfspr(SPRN_SVR);
>> + if (svid == 0x80480021) {
>> + void __iomem *immap;
>> +
>> + immap = ioremap(get_immrbase() + 0x14a8, 8);
>
> we should add a proper device node to cover whatever register space this
> is.
Hmm... in the MPC8360ERM.pdf this is a "reserved" register ... This
"register" is mentioned in the MPC8360ECE.pdf for this CPU in
Table 4. RGMII Programmable I/O Delay Work Arounds in the QE_ENET10
section.
So this is a MPC8360E, MPC8358E specific errata, so shouldn;t
we add this fix in the drivers/net/ucc_geth.c driver so all
boards have this fix?
thanks for commenting
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-04-23 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 6:09 [PATCH] 83xx: add support for the kmeter1 board Heiko Schocher
2009-04-23 14:25 ` Kumar Gala
2009-04-23 14:50 ` Heiko Schocher [this message]
2009-04-27 5:38 ` Heiko Schocher
2009-04-27 18:05 ` Scott Wood
2009-04-28 4:42 ` Heiko Schocher
2009-04-28 16:35 ` Scott Wood
2009-04-29 4:48 ` [PATCH v2] " Heiko Schocher
2009-06-11 2:43 ` Kumar Gala
2009-06-11 6:03 ` Heiko Schocher
2009-06-11 6:16 ` [PATCH v3] " Heiko Schocher
2009-06-11 14:10 ` Kumar Gala
2009-06-11 18:08 ` Heiko Schocher
2009-06-11 18:10 ` [PATCH v4] " Heiko Schocher
2009-06-12 1:13 ` David Gibson
2009-06-12 5:27 ` Heiko Schocher
2009-06-15 2:42 ` David Gibson
2009-06-15 7:38 ` [PATCH v5] " Heiko Schocher
2009-06-16 3:16 ` Kumar Gala
2009-05-07 17:49 ` [PATCH] " Varlese, Christopher
2009-05-08 5:44 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F08023.4060607@denx.de \
--to=hs@denx$(echo .)de \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox