From: Heiko Schocher <hs@denx•de>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] 83xx: add support for the kmeter1 board.
Date: Tue, 28 Apr 2009 06:42:43 +0200 [thread overview]
Message-ID: <49F68943.3090800@denx.de> (raw)
In-Reply-To: <20090427180503.GB10292@ld0162-tx32.am.freescale.net>
Hello Scott,
Scott Wood wrote:
> On Mon, Apr 27, 2009 at 07:38:38AM +0200, Heiko Schocher wrote:
>> 1) add in the soc node an "errata" node and in this "errata" node
>> we can add all CPU specific errata as an example the qe_enet10
>> errata, which above code covers:
>
> What about errata discovered after the device tree is deployed?
Didn;t know that there are such errata. Ok, this is a problem.
>> soc8360@e0000000 {
>> [...]
>> errata {
>> device_type = "errata";
>
> device_type is deprecated except for a couple of legacy uses. Please do
> not add new ones.
Ok.
>> compatible = "fsl,mpc83xx_errata";
>
> To be bound to by an "errata driver"? :-P
Why not ;-) ?
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>> qe_enet10@14a8 {
>> device_type = "errata";
>> compatible = "fsl,mpc83xx_errata_qe_enet10";
>> reg = <0x14a8 0x08>;
>
> But that register is part of the "QE parallel I/O port" block (even if it
> happens to be undocumented within that block), not part of the "QE ENET10
> erratum" block. The device tree describes the hardware, not what you
> want to do with it.
Hmm.. isn;t this an errata for a buggy hardware? Why not describing this
in the dts?
> The presence of the erratum itself is indicated by the presence of the
> buggy device, possibly in conjunction with SVR if the device tree is not
> specific enough.
Ah, Ok, that was just an idea ... so, where and how to solve the qe_enet10
errata without using get_immrbase() (and I vote not to solve it as it
actuall is in board specific code, maybe as i proposed in an earlier mail
in the ucc_geth.c driver?)?
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-04-28 5:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 6:09 [PATCH] 83xx: add support for the kmeter1 board Heiko Schocher
2009-04-23 14:25 ` Kumar Gala
2009-04-23 14:50 ` Heiko Schocher
2009-04-27 5:38 ` Heiko Schocher
2009-04-27 18:05 ` Scott Wood
2009-04-28 4:42 ` Heiko Schocher [this message]
2009-04-28 16:35 ` Scott Wood
2009-04-29 4:48 ` [PATCH v2] " Heiko Schocher
2009-06-11 2:43 ` Kumar Gala
2009-06-11 6:03 ` Heiko Schocher
2009-06-11 6:16 ` [PATCH v3] " Heiko Schocher
2009-06-11 14:10 ` Kumar Gala
2009-06-11 18:08 ` Heiko Schocher
2009-06-11 18:10 ` [PATCH v4] " Heiko Schocher
2009-06-12 1:13 ` David Gibson
2009-06-12 5:27 ` Heiko Schocher
2009-06-15 2:42 ` David Gibson
2009-06-15 7:38 ` [PATCH v5] " Heiko Schocher
2009-06-16 3:16 ` Kumar Gala
2009-05-07 17:49 ` [PATCH] " Varlese, Christopher
2009-05-08 5:44 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F68943.3090800@denx.de \
--to=hs@denx$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox