From: Felix Radensky <felix@embedded-sol•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Stef van Os <stef.van.os@Prodrive•nl>, Stefan Roese <sr@denx•de>,
Feng Kan <fkan@amcc•com>,
linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards
Date: Wed, 20 Jan 2010 00:52:22 +0200 [thread overview]
Message-ID: <4B5637A6.5070600@embedded-sol.com> (raw)
In-Reply-To: <1263444961.724.343.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Wed, 2010-01-13 at 10:18 +1100, Benjamin Herrenschmidt wrote:
>
>> On Tue, 2010-01-12 at 15:09 +0100, Stef van Os wrote:
>>
>>> This patch adds type 1 PCI transactions to 4xx PCI code, enabling the
>>> discovery of
>>> devices behind a PCI bridge.
>>>
>> Your patch appears word wrapped and whitespace damaged...
>>
>> I'll fix it up manually this time around but please check your mailer
>> setup :-)
>>
>
> Allright, it's not quite that.
>
> I've looked at my docs, and it looks like older parts such as the 440EP
> do -not- take the config type in the low bit.
>
> More interestingly, they only generate config 0 cycles if you pass a bus
> number of 0 :-)
>
> So we'll need do do something a little bit different here. We probably
> need to indicate in the device-tree what kind of SoC we have (whether
> it supports the explicit bit to choose between type 0 and type 1 or
> not).
>
> If not, we should then set the "self_busno" field of the bridge to 0,
> causing indirect_pci to always use bus number 0 when trying to talk
> to the bus segment behind the bridge, whatever the linux bus number
> for it actually is.
>
> Now, we need to make a precise list here of what SoC uses what. 460xx
> seem to all support the explicit bit. 440EP doesn't. What else ?
>
> Somebody from AMCC can dbl check that ?
>
I've checked what platforms take configuration type in the lower bit:
405XX - no
440EP - no
440GR - no
440EPx/440GRx - no
440GP - yes
440GX - yes
440SP - yes
440SPe - yes
460XX - yes
The distinction between these groups is pretty clear in the device trees.
The members of the first group all have "ibm,plb-pci" property, and all
members of second group have "ibm,plb-pcix" property.
So only ppc4xx_probe_pcix_bridge() routine should be fixed.
Felix.
next prev parent reply other threads:[~2010-01-19 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 14:09 [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards Stef van Os
2010-01-12 23:18 ` Benjamin Herrenschmidt
2010-01-14 4:56 ` Benjamin Herrenschmidt
2010-01-19 22:52 ` Felix Radensky [this message]
2010-01-19 22:57 ` Benjamin Herrenschmidt
2010-01-20 11:21 ` Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5637A6.5070600@embedded-sol.com \
--to=felix@embedded-sol$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=fkan@amcc$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sr@denx$(echo .)de \
--cc=stef.van.os@Prodrive$(echo .)nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox