From: Wolfgang Grandegger <wg@grandegger•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Ben Dooks <ben-linux@fluff•org>,
Devicetree-discuss@lists•ozlabs.org,
Linuxppc-dev@lists•ozlabs.org, Linux-i2c@vger•kernel.org,
Wolfgang Grandegger <wg@denx•de>
Subject: Re: [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings
Date: Tue, 09 Feb 2010 19:57:00 +0100 [thread overview]
Message-ID: <4B71AFFC.3010301@grandegger.com> (raw)
In-Reply-To: <fa686aa41002090950w2c3cd008k47784089dd3417d7@mail.gmail.com>
Hi Grant,
Grant Likely wrote:
> On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger <wg@grandegger•com> wrote:
>> From: Wolfgang Grandegger <wg@denx•de>
>>
>> This patch adds the MPC5121 to the list of supported devices,
>> enhances the doc of the "clock-frequency" property and removes
>> the obsolete "cell-index" property from the example nodes.
>> Furthermore and example for the MPC5121 has been added.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@denx•de>
>
> Thanks Wolfgang. Comments below.
>
>> ---
>> Documentation/powerpc/dts-bindings/fsl/i2c.txt | 30 +++++++++++++++++++----
>> 1 files changed, 24 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/powerpc/dts-bindings/fsl/i2c.txt b/Documentation/powerpc/dts-bindings/fsl/i2c.txt
>> index b6d2e21..2f62dae 100644
>> --- a/Documentation/powerpc/dts-bindings/fsl/i2c.txt
>> +++ b/Documentation/powerpc/dts-bindings/fsl/i2c.txt
>> @@ -9,8 +9,9 @@ Recommended properties :
>>
>> - compatible : compatibility list with 2 entries, the first should
>> be "fsl,CHIP-i2c" where CHIP is the name of a compatible processor,
>> - e.g. mpc8313, mpc8543, mpc8544, mpc5200 or mpc5200b. The second one
>> - should be "fsl-i2c".
>> + e.g. mpc8313, mpc8543, mpc8544, mpc5121, mpc5200 or mpc5200b. The
>> + second one should be "fsl-i2c". For the mpc5121, an additional node
>> + "fsl,mpc5121-i2c-ctrl" is required as shown in the example below.
>
> While you're editing this line; drop the requirement for the second
> value to be 'fsl-i2c'. We don't use it anymore, and only preserve it
> for backwards compatibility with old trees.
OK.
>> - interrupts : <a b> where a is the interrupt number and b is a
>> field that represents an encoding of the sense and level
>> information for the interrupt. This should be encoded based on
>> @@ -20,29 +21,46 @@ Recommended properties :
>> services interrupts for this device.
>> - fsl,preserve-clocking : boolean; if defined, the clock settings
>> from the bootloader are preserved (not touched).
>> - - clock-frequency : desired I2C bus clock frequency in Hz.
>> + - clock-frequency : desired I2C bus clock frequency in Hz. If this
>> + property and "fsl,preserve-clocking" is not defined, a safe fixed
>> + clock divider value is used (resulting in a small clock frequency).
>
> Nah, leave this as is. Don't make it sound like omitting both
> properties is a valid option. The driver may (and should!) handle the
> situation gracefully, but that fact does not need to be documented.
The safe value is not a good choice, indeed. Then it will also change
MPC_I2C_CLOCK_SAFE to MPC_I2C_CLOCK_LEGACY in i2c-mpc.c.
I will also fix the other issues you commented on.
Thanks,
Wolfgang.
next prev parent reply other threads:[~2010-02-09 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 13:25 [PATCH v4 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings Wolfgang Grandegger
2010-01-29 16:26 ` Wolfram Sang
2010-02-09 17:50 ` Grant Likely
2010-02-09 18:57 ` Wolfgang Grandegger [this message]
2010-02-09 19:23 ` Wolfgang Grandegger
2010-02-09 22:15 ` Grant Likely
2010-01-29 16:24 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfram Sang
2010-02-09 17:45 ` Grant Likely
2010-01-29 16:15 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Wolfram Sang
2010-02-09 17:41 ` Grant Likely
2010-02-10 10:09 ` Wolfgang Grandegger
2010-02-10 10:32 ` Stephen Rothwell
2010-02-10 10:53 ` Wolfgang Grandegger
2010-02-10 14:14 ` Grant Likely
2010-02-10 14:45 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B71AFFC.3010301@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=Linux-i2c@vger$(echo .)kernel.org \
--cc=Linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ben-linux@fluff$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=wg@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox