From: Wolfgang Grandegger <wg@grandegger•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Devicetree-discuss@lists•ozlabs.org, Linux-i2c@vger•kernel.org,
Ben Dooks <ben-linux@fluff•org>,
Linuxppc-dev@lists•ozlabs.org, Wolfgang Grandegger <wg@denx•de>
Subject: Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data
Date: Wed, 10 Feb 2010 15:45:30 +0100 [thread overview]
Message-ID: <4B72C68A.8020300@grandegger.com> (raw)
In-Reply-To: <fa686aa41002100614l76bff396ved847c0b0a4c71ff@mail.gmail.com>
Grant Likely wrote:
> On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger <wg@grandegger•com> wrote:
>> Stephen Rothwell wrote:
>>> Hi Wolfgang,
>>>
>>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger <wg@grandegger•com> wrote:
>>>>> __devinitdata goes at the end, immediately before the '='. Ditto
>>>>> throughout the file.
>>>> This made a difference and revealed section mismatches. "const" seems to
>>>> be incompatible with "__devinitdata".
>>> Maybe try no "const" and "__devinitconst" (I am not sure if both will
>>> work).
>> Yes, that works, even together with "const". To avoid rolling out the
>> whole patch series again, I can prepare a follow-up patch fixing this issue.
>
> Nah, just resend this one patch.
Even if it break the following patches? Will resend v7 in a second.
Wolfgang.
prev parent reply other threads:[~2010-02-10 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 13:25 [PATCH v4 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfgang Grandegger
2010-01-28 13:25 ` [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings Wolfgang Grandegger
2010-01-29 16:26 ` Wolfram Sang
2010-02-09 17:50 ` Grant Likely
2010-02-09 18:57 ` Wolfgang Grandegger
2010-02-09 19:23 ` Wolfgang Grandegger
2010-02-09 22:15 ` Grant Likely
2010-01-29 16:24 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfram Sang
2010-02-09 17:45 ` Grant Likely
2010-01-29 16:15 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Wolfram Sang
2010-02-09 17:41 ` Grant Likely
2010-02-10 10:09 ` Wolfgang Grandegger
2010-02-10 10:32 ` Stephen Rothwell
2010-02-10 10:53 ` Wolfgang Grandegger
2010-02-10 14:14 ` Grant Likely
2010-02-10 14:45 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B72C68A.8020300@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=Linux-i2c@vger$(echo .)kernel.org \
--cc=Linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ben-linux@fluff$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wg@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox