From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Matt Evans <matt@ozlabs•org>
Cc: sarah.a.sharp@linux•intel.com, linuxppc-dev@ozlabs•org,
linux-usb@vger•kernel.org
Subject: Re: [PATCH 5/5] xhci: Remove recursive call to xhci_handle_event
Date: Fri, 25 Mar 2011 15:48:43 +0300 [thread overview]
Message-ID: <4D8C8F2B.9090808@ru.mvista.com> (raw)
In-Reply-To: <4D8C47D8.4020901@ozlabs.org>
Hello.
On 25-03-2011 10:44, Matt Evans wrote:
> Make the caller loop while there are events to handle, instead.
> Signed-off-by: Matt Evans<matt@ozlabs•org>
> ---
> drivers/usb/host/xhci-ring.c | 16 +++++++++-------
> 1 files changed, 9 insertions(+), 7 deletions(-)
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index b46efd9..97bedd6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
[...]
> @@ -2277,7 +2279,7 @@ hw_died:
> /* FIXME this should be a delayed service routine
> * that clears the EHB.
> */
> - xhci_handle_event(xhci);
> + while (xhci_handle_event(xhci)) {};
Semicolon not needed after }. Perhaps the committer could change this...
WBR, Sergei
next prev parent reply other threads:[~2011-03-25 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 7:44 [PATCH 5/5] xhci: Remove recursive call to xhci_handle_event Matt Evans
2011-03-25 12:48 ` Sergei Shtylyov [this message]
2011-03-28 4:53 ` [PATCH v2 " Matt Evans
2011-03-28 22:34 ` Sarah Sharp
2011-03-28 23:58 ` Benjamin Herrenschmidt
2011-03-29 18:34 ` Sarah Sharp
2011-03-29 20:00 ` Dmitry Torokhov
2011-03-30 7:51 ` David Laight
2011-03-30 23:10 ` Matt Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8C8F2B.9090808@ru.mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=matt@ozlabs$(echo .)org \
--cc=sarah.a.sharp@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox