From: Peter Korsgaard <jacmet@sunsite•dk>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] fsl_spi_init: Support non-QE processors
Date: Wed, 03 Oct 2007 18:04:50 +0200 [thread overview]
Message-ID: <874ph8xjz1.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <fa686aa40710030856u74054993q2d73cf18920665f2@mail.gmail.com> (Grant Likely's message of "Wed\, 3 Oct 2007 09\:56\:34 -0600")
>>>>> "Grant" == Grant Likely <grant.likely@secretlab•ca> writes:
Hi,
Grant> Why not just:
Grant> np = of_find_node_by_type(NULL, "qe");
Grant> + if (!np)
Grant> + np = of_find_node_by_type(NULL, "soc");
Grant> if (!np)
Grant> return -ENODEV;
My first iteration did it like that, but then you don't get a -ENODEV
if the node is missing (and you'll end up using the wrong clock) and
it doesn't support processors with SPI on and off QE (if that
exists/will ever exist).
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2007-10-03 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 15:43 [PATCH] fsl_spi_init: Support non-QE processors Peter Korsgaard
2007-10-03 15:56 ` Grant Likely
2007-10-03 16:04 ` Peter Korsgaard [this message]
2007-10-03 18:17 ` Grant Likely
2007-10-03 22:11 ` Kumar Gala
2007-10-04 4:01 ` Stephen Rothwell
2007-10-05 14:11 ` Kumar Gala
2007-10-06 20:06 ` Peter Korsgaard
2007-10-08 14:09 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ph8xjz1.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox