From: Peter Korsgaard <jacmet@sunsite•dk>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org, Timur Tabi <timur@freescale•com>
Subject: Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC
Date: Fri, 21 Sep 2007 09:35:03 +0200 [thread overview]
Message-ID: <874pholbdk.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20070920133528.GC14820@ld0162-tx32.am.freescale.net> (Scott Wood's message of "Thu\, 20 Sep 2007 08\:35\:28 -0500")
>>>>> "Scott" == Scott Wood <scottwood@freescale•com> writes:
Hi,
Scott> #size-cells is zero on i2c, so it should just be reg = <68>.
Scott> You'll probably need to add #address-cells and #size-cells to the
Scott> controller node, as well.
Ahh - Thanks. This should be better.
---
[PATCH] mpc8349emitx.dts: Add ds1339 RTC
Add ds1339 I2C RTC chip as child of 2nd I2C controller.
Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
---
arch/powerpc/boot/dts/mpc8349emitx.dts | 9 +++++++++
1 file changed, 9 insertions(+)
Index: linux/arch/powerpc/boot/dts/mpc8349emitx.dts
===================================================================
--- linux.orig/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ linux/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -62,12 +62,21 @@
};
i2c@3100 {
+ #address-cells = <1>;
+ #size-cells = <0>;
device_type = "i2c";
compatible = "fsl-i2c";
reg = <3100 100>;
interrupts = <f 8>;
interrupt-parent = < &ipic >;
dfsrr;
+
+ rtc@68 {
+ device_type = "rtc";
+ compatible = "dallas,ds1339";
+ reg = <68>;
+ };
+
};
spi@7000 {
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2007-09-21 7:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 10:42 [patch 0/3] fsl_soc / mpc8349emitx patches Peter Korsgaard
2007-09-20 10:42 ` [patch 1/3] fsl_soc: Fix trivial printk typo Peter Korsgaard
2007-09-20 10:42 ` [patch 2/3] fsl_soc: rtc-ds1307 support Peter Korsgaard
2007-09-20 10:42 ` [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC Peter Korsgaard
2007-09-20 13:35 ` Scott Wood
2007-09-21 7:35 ` Peter Korsgaard [this message]
2007-09-24 5:07 ` David Gibson
2007-09-24 5:52 ` Peter Korsgaard
2007-09-25 2:13 ` David Gibson
2007-09-25 5:33 ` Peter Korsgaard
2007-09-25 5:47 ` David Gibson
2007-09-24 6:13 ` Kumar Gala
2007-09-24 14:52 ` Scott Wood
2007-09-25 2:04 ` David Gibson
2007-09-24 21:11 ` Segher Boessenkool
2007-09-25 2:11 ` David Gibson
2007-09-25 20:33 ` Segher Boessenkool
2007-09-28 2:45 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pholbdk.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox