From: Peter Korsgaard <jacmet@sunsite•dk>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org, Timur Tabi <timur@freescale•com>
Subject: Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC
Date: Mon, 24 Sep 2007 07:52:22 +0200 [thread overview]
Message-ID: <878x6wpq3t.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20070924050709.GM8058@localhost.localdomain> (David Gibson's message of "Mon\, 24 Sep 2007 15\:07\:09 +1000")
>>>>> "David" == David Gibson <david@gibson•dropbear.id.au> writes:
Hi
>> compatible = "fsl-i2c";
>> reg = <3100 100>;
>> interrupts = <f 8>;
>> interrupt-parent = < &ipic >;
>> dfsrr;
>> +
>> + rtc@68 {
>> + device_type = "rtc";
>> + compatible = "dallas,ds1339";
>> + reg = <68>;
>> + };
David> I think we want to think a bit more carefully about how to do bindings
David> for RTC devices. No "rtc" device_type is defined, but again we might
David> want to.
Could be. I've simply done it like kuroboxHD.dts already does and
fsl_soc.c expects.
David> I did find one real OF binding for a different Dallas RTC (and NVRAM),
David> see:
David> http://playground.sun.com/1275/proposals/Closed/Remanded/Accepted/346-it.txt
David> It's a little different from the example above.
David> The fact that NVRAM+RTC chips are so common is a bit of an issue from
David> the point of view of defining a device class binding - a device can't
David> have type "rtc" and "nvram".
True. I think we should primarily focus on the RTC part rather than
NVRAM as that's the "main" functionality and leave a NVRAM class for
I2C EEPROMs.
The Linux driver for the chip (rtc-1307.c) doesn't expose the NVRAM
bytes either.
But I'm open for suggestions.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2007-09-24 5:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 10:42 [patch 0/3] fsl_soc / mpc8349emitx patches Peter Korsgaard
2007-09-20 10:42 ` [patch 1/3] fsl_soc: Fix trivial printk typo Peter Korsgaard
2007-09-20 10:42 ` [patch 2/3] fsl_soc: rtc-ds1307 support Peter Korsgaard
2007-09-20 10:42 ` [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC Peter Korsgaard
2007-09-20 13:35 ` Scott Wood
2007-09-21 7:35 ` Peter Korsgaard
2007-09-24 5:07 ` David Gibson
2007-09-24 5:52 ` Peter Korsgaard [this message]
2007-09-25 2:13 ` David Gibson
2007-09-25 5:33 ` Peter Korsgaard
2007-09-25 5:47 ` David Gibson
2007-09-24 6:13 ` Kumar Gala
2007-09-24 14:52 ` Scott Wood
2007-09-25 2:04 ` David Gibson
2007-09-24 21:11 ` Segher Boessenkool
2007-09-25 2:11 ` David Gibson
2007-09-25 20:33 ` Segher Boessenkool
2007-09-28 2:45 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878x6wpq3t.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox