From: Michael Ellerman <mpe@ellerman•id.au>
To: Mimi Zohar <zohar@linux•ibm.com>, linuxppc-dev@lists•ozlabs.org
Cc: nayna@linux•ibm.com, dja@axtens•net
Subject: Re: [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init
Date: Sat, 09 Apr 2022 23:04:15 +1000 [thread overview]
Message-ID: <87bkxa76i8.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <c97b7032d777853c2f4b8d2e7f9fc7a522ff891c.camel@linux.ibm.com>
Mimi Zohar <zohar@linux•ibm.com> writes:
> On Fri, 2022-04-08 at 13:31 -0400, Mimi Zohar wrote:
>> On Fri, 2022-04-08 at 12:05 -0400, Mimi Zohar wrote:
>> > On Fri, 2022-04-08 at 00:15 +1000, Michael Ellerman wrote:
>> > > We can mark arch_get_ima_policy() as __init because it's only caller
>> > > ima_init_arch_policy() is __init. We can then mark
>> > > is_ppc_trustedboot_enabled() __init because its only caller is
>> > > arch_get_ima_policy().
>> > >
>> > > Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
>> >
>> > I assume you want to upstream this via power,
>> >
>> > Reviewed-by: Mimi Zohar <zohar@linux•ibm.com>
>>
>> Sorry, I just noticed that is_ppc_trustedboot_enabled() is also called
>> by arch_ima_get_secureboot().
>
> Never mind, arch_ima_get_secureboot() calls
> is_ppc_secureboot_enabled(), not is_ppc_trustedboot_enabled().
Yeah despite the long names they are still easy to confuse :)
cheers
next prev parent reply other threads:[~2022-04-09 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:15 [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init Michael Ellerman
2022-04-08 16:05 ` Mimi Zohar
2022-04-08 17:31 ` Mimi Zohar
2022-04-08 17:46 ` Mimi Zohar
2022-04-09 13:04 ` Michael Ellerman [this message]
2022-04-09 13:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkxa76i8.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=dja@axtens$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nayna@linux$(echo .)ibm.com \
--cc=zohar@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox