From: Peter Korsgaard <jacmet@sunsite•dk>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, dan.j.williams@intel•com
Subject: Re: [PATCH] fsldma: print correct IRQ on mpc83xx
Date: Wed, 14 Jan 2009 17:15:28 +0100 [thread overview]
Message-ID: <87iqohc19b.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <496E0E85.7060801@freescale.com> (Timur Tabi's message of "Wed\, 14 Jan 2009 10\:10\:45 -0600")
>>>>> "Timur" == Timur Tabi <timur@freescale•com> writes:
Timur> Peter Korsgaard wrote:
>> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct fsl_dma_device *fdev,
>> }
>>
>> dev_info(fdev->dev, "#%d (%s), irq %d\n", new_fsl_chan->id,
>> - compatible, new_fsl_chan->irq);
>> + compatible,
>> + new_fsl_chan->irq != NO_IRQ ? new_fsl_chan->irq : fdev->irq);
Timur> Wouldn't it be better to make sure that, on 83xx,
Timur> new_fsl_chan->irq has the same value as fdev->irq before we
Timur> get here?
Why? Does it buy us anything to request_irq again for each channel?
Now we're at it, it seems like there's a check for != NO_IRQ missing
in fsl_dma_chan_remove().
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-14 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:44 [PATCH] fsldma: print correct IRQ on mpc83xx Peter Korsgaard
2009-01-14 16:10 ` Timur Tabi
2009-01-14 16:15 ` Peter Korsgaard [this message]
2009-01-14 16:30 ` Timur Tabi
2009-01-14 16:38 ` Peter Korsgaard
2009-01-14 16:42 ` Timur Tabi
2009-01-14 19:29 ` Peter Korsgaard
2009-01-14 19:30 ` Timur Tabi
2009-01-15 6:17 ` Dan Williams
2009-01-15 11:21 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqohc19b.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=dan.j.williams@intel$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox