From: Peter Korsgaard <jacmet@sunsite•dk>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, dan.j.williams@intel•com
Subject: Re: [PATCH] fsldma: print correct IRQ on mpc83xx
Date: Wed, 14 Jan 2009 20:29:15 +0100 [thread overview]
Message-ID: <87ab9tbsac.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <496E15E8.2060106@freescale.com> (Timur Tabi's message of "Wed\, 14 Jan 2009 10\:42\:16 -0600")
>>>>> "Timur" == Timur Tabi <timur@freescale•com> writes:
Timur> Peter Korsgaard wrote:
>> Documentation/powerpc/dts-bindings/fsl/dma.txt and
>> The NO_IRQ check in fsldma.c:fsl_dma_chan_probe()
>>
>> And it makes sense, there's no per-channel DMAC interrupts on mpc83xx.
Timur> But the device trees do have IRQs in the channels:
Timur> arch/powerpc/boot/dts/mpc836x_mds.dts:
Timur> So I don't see what bug you're trying to fix. If you're
Timur> saying that the interrupts should not be specific DMA
Timur> channels, then the proper fix is to have the DMA driver pick
Timur> up the interrupts from the DMA controller's node when
Timur> necessary. Hacking up a printk doesn't fix anything.
Ok, let me try again. SOME device trees indeed have an interrupt
property per channel, but the bindings
(Documentation/powerpc/dts-bindings/fsl/dma.txt) and the probe code in
fsldma.c doesn't require it.
The only minor issues we have is the cosmetic problem of the driver
printing NO_IRQ (E.G. this patch), and the driver calling
free_irq(NO_IRQ) (E.G. the other patch I sent today) in the release
path.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-14 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:44 [PATCH] fsldma: print correct IRQ on mpc83xx Peter Korsgaard
2009-01-14 16:10 ` Timur Tabi
2009-01-14 16:15 ` Peter Korsgaard
2009-01-14 16:30 ` Timur Tabi
2009-01-14 16:38 ` Peter Korsgaard
2009-01-14 16:42 ` Timur Tabi
2009-01-14 19:29 ` Peter Korsgaard [this message]
2009-01-14 19:30 ` Timur Tabi
2009-01-15 6:17 ` Dan Williams
2009-01-15 11:21 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab9tbsac.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=dan.j.williams@intel$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox