From: Thomas Gleixner <tglx@linutronix•de>
To: Eliav Farber <farbere@amazon•com>,
linux@armlinux•org.uk, catalin.marinas@arm•com, will@kernel•org,
mpe@ellerman•id.au, npiggin@gmail•com,
christophe.leroy@csgroup•eu, naveen@kernel•org,
maddy@linux•ibm.com, paul.walmsley@sifive•com,
palmer@dabbelt•com, aou@eecs•berkeley.edu,
akpm@linux-foundation•org, bhe@redhat•com, farbere@amazon•com,
hbathini@linux•ibm.com, adityag@linux•ibm.com,
songshuaishuai@tinylab•org, takakura@valinux•co.jp,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-riscv@lists•infradead.org
Cc: jonnyc@amazon•com
Subject: Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking
Date: Thu, 28 Nov 2024 11:43:20 +0100 [thread overview]
Message-ID: <87ldx3y6yf.ffs@tglx> (raw)
In-Reply-To: <20241127152236.26122-1-farbere@amazon.com>
On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote:
As a related note. The subject line is not really matching what the
patch does. It want's to be split into a core change and one patch per
architecture.
> This patch replaces the direct invocation of the irq_mask() and
git grep 'This patch' Documentation/process/
> irq_disable() hooks with simplified code that leverages the
> irq_disable() kernel infrastructure. This higher-level function checks
> the interrupt's state to prevent redundant operations. Additionally, the
> IRQ_DISABLE_UNLAZY status flag is set to ensure that, for interrupt
> chips lacking an irq_disable callback, the disable operation is handled
> using the lazy approach.
Not that it matters much anymore, but the last sentence does not make
sense:
Set the UNLAZY flag so disable is handled using the LAZY approach ...
Thanks,
tglx
next prev parent reply other threads:[~2024-11-28 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 15:22 [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking Eliav Farber
2024-11-28 10:39 ` Thomas Gleixner
2024-11-28 10:43 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-28 20:07 Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldx3y6yf.ffs@tglx \
--to=tglx@linutronix$(echo .)de \
--cc=adityag@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bhe@redhat$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=farbere@amazon$(echo .)com \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=jonnyc@amazon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=songshuaishuai@tinylab$(echo .)org \
--cc=takakura@valinux$(echo .)co.jp \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox