From: Peter Korsgaard <jacmet@sunsite•dk>
To: avorontsov@ru•mvista.com
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings
Date: Fri, 05 Sep 2008 20:45:33 +0200 [thread overview]
Message-ID: <87tzcuctyq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080905161607.GA10826@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Fri\, 5 Sep 2008 20\:16\:07 +0400")
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru•mvista.com> writes:
Anton> On Fri, Sep 05, 2008 at 05:08:47PM +0200, Peter Korsgaard wrote:
>> Structured similar to the existing QE GPIO support.
>>
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
>> ---
Anton> I posted identical driver in June. ;-)
Anton> http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057395.html
Ahh, I must have missed it back then. Seems like you never got any
feedback on it - Now, as we both independently got to ~same result, it
must be a good approach ;) Kumar, what do you say?
>From a quick look, your driver seems to set the data / direction
registers in the wrong order in fsl_gpio_dir_out causing a glitch with
high level outputs:
http://peter.korsgaard.com/patches/uboot/mpc83xx-gpio-level-before-direction.patch
(Never seems to have made it to the U-Boot list archive, but it's in
git now).
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-09-05 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 15:08 [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings Peter Korsgaard
2008-09-05 16:16 ` Anton Vorontsov
2008-09-05 18:45 ` Peter Korsgaard [this message]
2008-09-05 21:53 ` Anton Vorontsov
2008-09-19 18:10 ` Kumar Gala
2008-09-21 18:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzcuctyq.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox