From: Peter Korsgaard <jacmet@sunsite•dk>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx•com>
Cc: linuxppc-dev@ozlabs•org, simekm2@fel•cvut.cz
Subject: Re: [PATCH 7/7] [POWERPC] Xilinx: Uartlite: Section type fixups
Date: Wed, 09 Jan 2008 12:24:48 +0100 [thread overview]
Message-ID: <87ve63w8an.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080108193519.5282318F8069@mail8-blu.bigfish.com> (Stephen Neuendorffer's message of "Tue\, 8 Jan 2008 11\:35\:09 -0800")
>>>>> "Stephen" == Stephen Neuendorffer <stephen.neuendorffer@xilinx•com> writes:
Stephen> All the __devexit functions are now appropriately tagged. This fixes
Stephen> some ppc link warnings.
You forgot to add __devexit_p(ulite_remove) in ulite_platform_driver,
otherwise:
Acked-by: Peter Korsgaard <jacmet@sunsite•dk>
Stephen> Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx•com>
Stephen> ---
Stephen> drivers/serial/uartlite.c | 4 ++--
Stephen> 1 files changed, 2 insertions(+), 2 deletions(-)
Stephen> diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
Stephen> index 02c2d89..ecd5540 100644
Stephen> --- a/drivers/serial/uartlite.c
Stephen> +++ b/drivers/serial/uartlite.c
Stephen> @@ -594,7 +594,7 @@ static int __devinit ulite_assign(struct device *dev, int id, u32 base, int irq)
Stephen> *
Stephen> * @dev: pointer to device structure
Stephen> */
Stephen> -static int __devinit ulite_release(struct device *dev)
Stephen> +static int __devexit ulite_release(struct device *dev)
Stephen> {
Stephen> struct uart_port *port = dev_get_drvdata(dev);
Stephen> int rc = 0;
Stephen> @@ -627,7 +627,7 @@ static int __devinit ulite_probe(struct platform_device *pdev)
Stephen> return ulite_assign(&pdev->dev, pdev->id, res->start, res2->start);
Stephen> }
Stephen> -static int ulite_remove(struct platform_device *pdev)
Stephen> +static int __devexit ulite_remove(struct platform_device *pdev)
Stephen> {
Stephen> return ulite_release(&pdev->dev);
Stephen> }
Stephen> --
Stephen> 1.5.3.4-dirty
Stephen> _______________________________________________
Stephen> Linuxppc-dev mailing list
Stephen> Linuxppc-dev@ozlabs•org
Stephen> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2008-01-09 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1199820909-32341-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 1/7] [POWERPC] Xilinx: Uartlite: Make console output actually work Stephen Neuendorffer
2008-01-09 11:20 ` Peter Korsgaard
[not found] ` <1199820909-32341-2-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 2/7] [POWERPC] Xilinx: update compatible list for interrupt controller Stephen Neuendorffer
[not found] ` <1199820909-32341-3-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 3/7] [POWERPC] Xilinx: Update compatible to use values generated by BSP generator Stephen Neuendorffer
[not found] ` <1199820909-32341-4-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 4/7] [POWERPC] Xilinx: Add correct compatible list for device tree bus bindings Stephen Neuendorffer
2008-01-09 0:55 ` Stephen Rothwell
[not found] ` <1199820909-32341-5-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 5/7] [POWERPC] Xilinx: Update booting-without-of Stephen Neuendorffer
[not found] ` <1199820909-32341-6-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 6/7] [POWERPC] Xilinx: updated device tree compatibility to match uboot bsp generator Stephen Neuendorffer
[not found] ` <1199820909-32341-7-git-send-email-stephen.neuendorffer@xilinx.com>
2008-01-08 19:35 ` [PATCH 7/7] [POWERPC] Xilinx: Uartlite: Section type fixups Stephen Neuendorffer
2008-01-09 11:24 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ve63w8an.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=simekm2@fel$(echo .)cvut.cz \
--cc=stephen.neuendorffer@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox