From: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
To: Jinjie Ruan <ruanjinjie@huawei•com>,
corbet@lwn•net, skhan@linuxfoundation•org,
catalin.marinas@arm•com, will@kernel•org, chenhuacai@kernel•org,
kernel@xen0n•name, maddy@linux•ibm.com, mpe@ellerman•id.au,
npiggin@gmail•com, chleroy@kernel•org, pjw@kernel•org,
palmer@dabbelt•com, aou@eecs•berkeley.edu, alex@ghiti•fr,
tglx@kernel•org, mingo@redhat•com, bp@alien8•de,
dave.hansen@linux•intel.com, hpa@zytor•com,
akpm@linux-foundation•org, bhe@redhat•com, vgoyal@redhat•com,
dyoung@redhat•com, rdunlap@infradead•org, pmladek@suse•com,
dapeng1.mi@linux•intel.com, kees@kernel•org, paulmck@kernel•org,
lirongqing@baidu•com, arnd@arndb•de, ardb@kernel•org,
leitao@debian•org, rppt@kernel•org, cfsworks@gmail•com,
ryan.roberts@arm•com, sourabhjain@linux•ibm.com,
tangyouling@kylinos•cn, eajames@linux•ibm.com,
hbathini@linux•ibm.com, songshuaishuai@tinylab•org,
samuel.holland@sifive•com, kevin.brodsky@arm•com,
vishal.moola@gmail•com, junhui.liu@pigmoral•tech,
coxu@redhat•com, liaoyuanhong@vivo•com,
fuqiang.wang@easystack•cn, jbohac@suse•cz, brgerst@gmail•com,
x86@kernel•org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, loongarch@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
kexec@lists•infradead.org
Cc: ruanjinjie@huawei•com
Subject: Re: [PATCH v6 1/5] powerpc/crash: sort crash memory ranges before preparing elfcorehdr
Date: Wed, 25 Feb 2026 08:45:56 +0530 [thread overview]
Message-ID: <87wm01h5sj.ritesh.list@gmail.com> (raw)
In-Reply-To: <20260224085342.387996-2-ruanjinjie@huawei.com>
Jinjie Ruan <ruanjinjie@huawei•com> writes:
> From: Sourabh Jain <sourabhjain@linux•ibm.com>
>
> During a memory hot-remove event, the elfcorehdr is rebuilt to exclude
> the removed memory. While updating the crash memory ranges for this
> operation, the crash memory ranges array can become unsorted. This
> happens because remove_mem_range() may split a memory range into two
> parts and append the higher-address part as a separate range at the end
> of the array.
>
> So far, no issues have been observed due to the unsorted crash memory
> ranges. However, this could lead to problems once crash memory range
> removal is handled by generic code, as introduced in the upcoming
> patches in this series.
>
> Currently, powerpc uses a platform-specific function,
> remove_mem_range(), to exclude hot-removed memory from the crash memory
> ranges. This function performs the same task as the generic
> crash_exclude_mem_range() in crash_core.c. The generic helper also
> ensures that the crash memory ranges remain sorted. So remove the
> redundant powerpc-specific implementation and instead call
> crash_exclude_mem_range_guarded() (which internally calls
> crash_exclude_mem_range()) to exclude the hot-removed memory ranges.
>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: Baoquan he <bhe@redhat•com>
> Cc: Jinjie Ruan <ruanjinjie@huawei•com>
> Cc: Hari Bathini <hbathini@linux•ibm.com>
> Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
> Cc: Mahesh Salgaonkar <mahesh@linux•ibm.com>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
> Cc: Shivang Upadhyay <shivangu@linux•ibm.com>
> Cc: linux-kernel@vger•kernel.org
> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel•org>
> Signed-off-by: Sourabh Jain <sourabhjain@linux•ibm.com>
I had gone through the generic implementation v/s the powerpc specific
remove_mem_range() implementation, when it was posted by Sourabh
separately. And it make sense to use the generic implementation in this
case, rather than keeping a duplicate powerpc specific version. So...
LGTM. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
next prev parent reply other threads:[~2026-02-25 3:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 8:53 [PATCH v6 0/5] arm64/riscv: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 1/5] powerpc/crash: sort crash memory ranges before preparing elfcorehdr Jinjie Ruan
2026-02-25 3:15 ` Ritesh Harjani [this message]
2026-02-26 9:24 ` Baoquan He
2026-02-26 9:35 ` Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 2/5] crash: Exclude crash kernel memory in crash core Jinjie Ruan
2026-02-26 9:29 ` Baoquan He
2026-02-24 8:53 ` [PATCH v6 3/5] crash: Use crash_exclude_core_ranges() on powerpc Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 4/5] arm64: kexec: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-25 15:48 ` Mike Rapoport
2026-02-26 3:24 ` Jinjie Ruan
2026-02-26 9:33 ` Baoquan He
2026-02-24 8:53 ` [PATCH v6 5/5] riscv: " Jinjie Ruan
2026-02-25 15:50 ` [PATCH v6 0/5] arm64/riscv: " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm01h5sj.ritesh.list@gmail.com \
--to=ritesh.list@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bhe@redhat$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cfsworks@gmail$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=coxu@redhat$(echo .)com \
--cc=dapeng1.mi@linux$(echo .)intel.com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dyoung@redhat$(echo .)com \
--cc=eajames@linux$(echo .)ibm.com \
--cc=fuqiang.wang@easystack$(echo .)cn \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jbohac@suse$(echo .)cz \
--cc=junhui.liu@pigmoral$(echo .)tech \
--cc=kees@kernel$(echo .)org \
--cc=kernel@xen0n$(echo .)name \
--cc=kevin.brodsky@arm$(echo .)com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=leitao@debian$(echo .)org \
--cc=liaoyuanhong@vivo$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lirongqing@baidu$(echo .)com \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=pjw@kernel$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rppt@kernel$(echo .)org \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=samuel.holland@sifive$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=songshuaishuai@tinylab$(echo .)org \
--cc=sourabhjain@linux$(echo .)ibm.com \
--cc=tangyouling@kylinos$(echo .)cn \
--cc=tglx@kernel$(echo .)org \
--cc=vgoyal@redhat$(echo .)com \
--cc=vishal.moola@gmail$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox