From: Baoquan He <bhe@redhat•com>
To: Jinjie Ruan <ruanjinjie@huawei•com>
Cc: corbet@lwn•net, skhan@linuxfoundation•org,
catalin.marinas@arm•com, will@kernel•org, chenhuacai@kernel•org,
kernel@xen0n•name, maddy@linux•ibm.com, mpe@ellerman•id.au,
npiggin@gmail•com, chleroy@kernel•org, pjw@kernel•org,
palmer@dabbelt•com, aou@eecs•berkeley.edu, alex@ghiti•fr,
tglx@kernel•org, mingo@redhat•com, bp@alien8•de,
dave.hansen@linux•intel.com, hpa@zytor•com,
akpm@linux-foundation•org, vgoyal@redhat•com, dyoung@redhat•com,
rdunlap@infradead•org, pmladek@suse•com,
dapeng1.mi@linux•intel.com, kees@kernel•org, paulmck@kernel•org,
lirongqing@baidu•com, arnd@arndb•de, ardb@kernel•org,
leitao@debian•org, rppt@kernel•org, cfsworks@gmail•com,
ryan.roberts@arm•com, sourabhjain@linux•ibm.com,
tangyouling@kylinos•cn, eajames@linux•ibm.com,
hbathini@linux•ibm.com, ritesh.list@gmail•com,
songshuaishuai@tinylab•org, samuel.holland@sifive•com,
kevin.brodsky@arm•com, vishal.moola@gmail•com,
junhui.liu@pigmoral•tech, coxu@redhat•com, liaoyuanhong@vivo•com,
fuqiang.wang@easystack•cn, jbohac@suse•cz, brgerst@gmail•com,
x86@kernel•org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, loongarch@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
kexec@lists•infradead.org
Subject: Re: [PATCH v6 4/5] arm64: kexec: Add support for crashkernel CMA reservation
Date: Thu, 26 Feb 2026 17:33:36 +0800 [thread overview]
Message-ID: <aaATcPGToAxEVIvh@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20260224085342.387996-5-ruanjinjie@huawei.com>
On 02/24/26 at 04:53pm, Jinjie Ruan wrote:
> Commit 35c18f2933c5 ("Add a new optional ",cma" suffix to the
> crashkernel= command line option") and commit ab475510e042 ("kdump:
> implement reserve_crashkernel_cma") added CMA support for kdump
> crashkernel reservation.
>
> Crash kernel memory reservation wastes production resources if too
> large, risks kdump failure if too small, and faces allocation difficulties
> on fragmented systems due to contiguous block constraints. The new
> CMA-based crashkernel reservation scheme splits the "large fixed
> reservation" into a "small fixed region + large CMA dynamic region": the
> CMA memory is available to userspace during normal operation to avoid
> waste, and is reclaimed for kdump upon crash—saving memory while
> improving reliability.
>
> So extend crashkernel CMA reservation support to arm64. The following
> changes are made to enable CMA reservation:
>
> - Parse and obtain the CMA reservation size along with other crashkernel
> parameters.
> - Call reserve_crashkernel_cma() to allocate the CMA region for kdump.
> - Include the CMA-reserved ranges for kdump kernel to use.
> - Exclude the CMA-reserved ranges from the crash kernel memory to
> prevent them from being exported through /proc/vmcore, which is already
> done in the crash core.
>
> Update kernel-parameters.txt to document CMA support for crashkernel on
> arm64 architecture.
>
> Acked-by: Ard Biesheuvel <ardb@kernel•org>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei•com>
> ---
> v3:
> - Add Acked-by.
> v2:
> - Free cmem in prepare_elf_headers()
> - Add the mtivation.
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> arch/arm64/kernel/machine_kexec_file.c | 8 +++++++-
> arch/arm64/mm/init.c | 5 +++--
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index cb850e5290c2..497f63b76898 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1121,7 +1121,7 @@ Kernel parameters
> It will be ignored when crashkernel=X,high is not used
> or memory reserved is below 4G.
> crashkernel=size[KMG],cma
> - [KNL, X86, ppc] Reserve additional crash kernel memory from
> + [KNL, X86, ARM64, ppc] Reserve additional crash kernel memory from
~~~~
This should be written as 'PPC', even though it's not introduced in this patch.
===
PPC PowerPC architecture is enabled.
===
Other than this nit, the overral looks good to me.
> CMA. This reservation is usable by the first system's
> userspace memory and kernel movable allocations (memory
> balloon, zswap). Pages allocated from this memory range
......snip...
next prev parent reply other threads:[~2026-02-26 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 8:53 [PATCH v6 0/5] arm64/riscv: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 1/5] powerpc/crash: sort crash memory ranges before preparing elfcorehdr Jinjie Ruan
2026-02-25 3:15 ` Ritesh Harjani
2026-02-26 9:24 ` Baoquan He
2026-02-26 9:35 ` Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 2/5] crash: Exclude crash kernel memory in crash core Jinjie Ruan
2026-02-26 9:29 ` Baoquan He
2026-02-24 8:53 ` [PATCH v6 3/5] crash: Use crash_exclude_core_ranges() on powerpc Jinjie Ruan
2026-02-24 8:53 ` [PATCH v6 4/5] arm64: kexec: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-25 15:48 ` Mike Rapoport
2026-02-26 3:24 ` Jinjie Ruan
2026-02-26 9:33 ` Baoquan He [this message]
2026-02-24 8:53 ` [PATCH v6 5/5] riscv: " Jinjie Ruan
2026-02-25 15:50 ` [PATCH v6 0/5] arm64/riscv: " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaATcPGToAxEVIvh@MiWiFi-R3L-srv \
--to=bhe@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cfsworks@gmail$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=coxu@redhat$(echo .)com \
--cc=dapeng1.mi@linux$(echo .)intel.com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dyoung@redhat$(echo .)com \
--cc=eajames@linux$(echo .)ibm.com \
--cc=fuqiang.wang@easystack$(echo .)cn \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jbohac@suse$(echo .)cz \
--cc=junhui.liu@pigmoral$(echo .)tech \
--cc=kees@kernel$(echo .)org \
--cc=kernel@xen0n$(echo .)name \
--cc=kevin.brodsky@arm$(echo .)com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=leitao@debian$(echo .)org \
--cc=liaoyuanhong@vivo$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lirongqing@baidu$(echo .)com \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=pjw@kernel$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=ritesh.list@gmail$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=samuel.holland@sifive$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=songshuaishuai@tinylab$(echo .)org \
--cc=sourabhjain@linux$(echo .)ibm.com \
--cc=tangyouling@kylinos$(echo .)cn \
--cc=tglx@kernel$(echo .)org \
--cc=vgoyal@redhat$(echo .)com \
--cc=vishal.moola@gmail$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox