From: Peter Korsgaard <jacmet@sunsite•dk>
To: Byron Bradley <byron.bbradley@gmail•com>
Cc: linuxppc-dev@ozlabs•org, tim.ellis@mac•com
Subject: Re: [PATCH] [POWERPC] 83xx: Add support for the Thecus N1200 NAS device
Date: Fri, 05 Jun 2009 09:31:53 +0200 [thread overview]
Message-ID: <87ws7rxhjq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090605030850.GF2054@yookeroo.seuss> (David Gibson's message of "Fri\, 5 Jun 2009 13\:08\:50 +1000")
>>>>> "David" == David Gibson <david@gibson•dropbear.id.au> writes:
David> On Thu, Jun 04, 2009 at 09:59:04PM +0100, Byron Bradley wrote:
>> The Thecus N1200 is a NAS device with a single internal SATA disk and
>> an eSATA port based on an MPC8347 SoC.
David> Comments on a number of fairly minor device tree nits below:
David> [snip]
>> + soc8349@e0000000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "soc";
>> + compatible = "simple-bus";
>> + };
>> +
>> + gpio1: gpio-controller@c00 {
>> + #gpio-cells = <2>;
>> + compatible = "fsl,mpc8347-gpio", "fsl,mpc8349-gpio";
David> This actually is an 8349 board, yes? Generally compatible should be
David> listed from most specific to least specific, so the 8349 entry should
David> go first.
No, it's an 8347, to the gpio compatible is fine, but the soc8349
should be changed to 8347 above.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-06-05 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 20:59 [PATCH] [POWERPC] 83xx: Add support for the Thecus N1200 NAS device Byron Bradley
2009-06-04 21:50 ` Kumar Gala
2009-06-04 22:11 ` Byron Bradley
2009-06-05 3:08 ` David Gibson
2009-06-05 7:31 ` Peter Korsgaard [this message]
2009-06-05 18:44 ` Byron Bradley
2009-06-06 3:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws7rxhjq.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=byron.bbradley@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tim.ellis@mac$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox