* dtc: Accept NOPs in dtb input regardless of version
@ 2007-06-26 1:30 David Gibson
2007-06-26 2:44 ` Jon Loeliger
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2007-06-26 1:30 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
Since Milton's patch, dtc will accept (and, correctly, ignore) NOP
tags when given dtb input v16 or later. However, although NOPs
weren't defined in earlier versions, they're not ambiguous, so should
be accepted there as well. This patch does so, printing a mere
warning when finding NOPs in a too-early dtb version.
Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Index: dtc/flattree.c
===================================================================
--- dtc.orig/flattree.c 2007-06-25 14:08:27.000000000 +1000
+++ dtc/flattree.c 2007-06-25 14:08:29.000000000 +1000
@@ -776,10 +776,12 @@
break;
case OF_DT_NOP:
- if (flags & FTF_NOPS)
+ if (!(flags & FTF_NOPS))
+ fprintf(stderr, "Warning: NOP tag found in flat tree"
+ " version <16\n");
break;
- die("OF_DT_NOP in device tree blob\n");
+ /* Ignore */
break;
default:
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: dtc: Accept NOPs in dtb input regardless of version
2007-06-26 1:30 dtc: Accept NOPs in dtb input regardless of version David Gibson
@ 2007-06-26 2:44 ` Jon Loeliger
0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2007-06-26 2:44 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
So, like, the other day David Gibson mumbled:
> Since Milton's patch, dtc will accept (and, correctly, ignore) NOP
> tags when given dtb input v16 or later. However, although NOPs
> weren't defined in earlier versions, they're not ambiguous, so should
> be accepted there as well. This patch does so, printing a mere
> warning when finding NOPs in a too-early dtb version.
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
Thanks,
jdl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-26 2:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-26 1:30 dtc: Accept NOPs in dtb input regardless of version David Gibson
2007-06-26 2:44 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox