From: Segher Boessenkool <segher@kernel•crashing.org>
To: "Mark A. Greer" <mgreer@mvista•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: [RFC/PATCH] powerpc: MPC7450 L2 HW cache flush feature utilization
Date: Fri, 15 Jun 2007 10:16:04 +0200 [thread overview]
Message-ID: <c6cd3a9fe7713f081354cca9b4306811@kernel.crashing.org> (raw)
In-Reply-To: <20070614222620.GA17382@mag.az.mvista.com>
>>>> /* TODO: use HW flush assist when available */
>>>
>>> You want to get rid of this old comment though -- and
>>> perhaps branch over the non-hardware-assisted cache
>>> flushing code.
>>
>> Ok, I agree that the comment is obsolete now. Would you please explain
>> why the branch over non-hardware-assisted code should be removed as
>> well. Technically the cache is flushed and there is no need to use
>> extra
>> commands to fill and then re-flush the cache.
>
> I think Segher is saying that you can skip the manual invalidation too
> (although he said "flushing", I think he really meant "invalidation"--
> the manual flushing is already skipped).
Erm yes.
> If I'm reading the manual
> correctly, L2HWF does the invalidation as well so both the manual
> flushing and invalidation can be skipped.
Yeah. Not that it really matters of course.
Segher
next prev parent reply other threads:[~2007-06-15 8:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 10:19 [RFC/PATCH] powerpc: MPC7450 L2 HW cache flush feature utilization Vladislav Buzov
2007-06-14 13:56 ` Segher Boessenkool
2007-06-14 17:12 ` Vladislav Buzov
2007-06-14 22:26 ` Mark A. Greer
2007-06-15 8:16 ` Segher Boessenkool [this message]
2007-06-15 8:55 ` Vladislav D. Buzov
2007-06-15 9:01 ` Segher Boessenkool
2007-06-15 9:33 ` Vladislav D. Buzov
2007-06-15 10:44 ` Segher Boessenkool
2007-06-15 8:14 ` Segher Boessenkool
2007-06-15 8:42 ` Vladislav D. Buzov
2007-06-15 8:56 ` Segher Boessenkool
2007-06-15 21:20 ` Mark A. Greer
2007-06-15 22:14 ` Segher Boessenkool
2007-06-21 12:37 ` Benjamin Herrenschmidt
2007-06-22 15:22 ` Vladislav Buzov
2007-06-23 15:46 ` Segher Boessenkool
2007-06-25 14:09 ` Vladislav Buzov
2007-06-28 8:24 ` Segher Boessenkool
2007-06-28 9:13 ` Benjamin Herrenschmidt
2007-06-28 10:47 ` Vladislav Buzov
2007-06-28 11:09 ` Benjamin Herrenschmidt
2007-06-25 19:00 ` Vladislav Buzov
2007-06-28 8:35 ` Segher Boessenkool
2007-06-29 10:41 ` Vladislav Buzov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6cd3a9fe7713f081354cca9b4306811@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mgreer@mvista$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox