From: Anthony Foiani <tkil@scrye•com>
To: Scott Wood <scottwood@freescale•com>
Cc: Adrian Bunk <bunk@stusta•de>,
"Robert P.J.Day" <rpjday@crashcourse•ca>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Shaohui.Xie@freescale•com, Li Yang-R58472 <r58472@freescale•com>
Subject: Re: ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS
Date: Fri, 23 Aug 2013 17:41:30 -0600 [thread overview]
Message-ID: <gppt4gel1.fsf@dworkin.scrye.com> (raw)
In-Reply-To: <20130823192532.GA29205@home.buserror.net> (Scott Wood's message of "Fri\, 23 Aug 2013 14\:25\:32 -0500")
Scott Wood <scottwood@freescale•com> writes:
>> --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
>> +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
>
> This should go in Documentation/devicetree/bindings/ata/fsl-sata.txt.
Ok, will change.
> As for the property name, I'd prefer "fsl,sata-speed-limit" or
> "fsl,sata-max-generation".
In my original patch:
http://article.gmane.org/gmane.linux.ports.ppc.embedded/58710
I used "fsl,sata-max-gen". I thought Jeff disliked it, so I changed
it be more generic -- but maybe I misread his complaint. (And while
his opinions are still respected, new maintainers might have different
tastes.)
I think my logic was that there exist "sata_spd_limit" and related
functions in the ata core, so I should mirror that in the dev tree.
No guarantees, though -- it's been a while since I wrote that code.
> Shaohui, do the driver bits look OK?
> This patch should go via the linux-scsi list (note that Tejun Heo is
> now the SATA maintainer).
linux-scsi, or linux-ide? My other recent change to sata_fsl went
through the latter.
Thanks for the review / comments. Let me know how you'd like to
proceed on the above points, and I can resubmit (as a proper patch for
easier tracking).
Best regards,
Anthony Foiani
next prev parent reply other threads:[~2013-08-23 23:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:25 ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS Scott Wood
2013-08-23 23:41 ` Anthony Foiani [this message]
2013-08-23 23:47 ` Scott Wood
2013-08-24 8:03 ` Anthony Foiani
2013-08-27 10:51 ` Xie Shaohui-B21989
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 17:08 Anthony Foiani
2012-05-21 6:31 ` Li Yang-R58472
2012-05-26 6:53 ` Anthony Foiani
2012-05-29 18:02 ` Scott Wood
2012-05-29 22:07 ` Anthony Foiani
2012-05-29 22:57 ` Scott Wood
2012-05-30 10:59 ` Li Yang
2012-05-30 20:07 ` Anthony Foiani
2012-05-30 20:14 ` Anthony Foiani
2012-05-30 20:20 ` Scott Wood
2012-05-30 20:52 ` Anthony Foiani
2013-04-30 6:41 ` Anthony Foiani
2013-04-30 18:15 ` Scott Wood
2013-05-01 0:34 ` Anthony Foiani
2013-05-01 0:42 ` Scott Wood
2013-05-01 2:06 ` Anthony Foiani
2013-05-01 18:05 ` Scott Wood
2013-05-01 23:35 ` Anthony Foiani
2013-05-02 0:13 ` Scott Wood
2013-04-30 21:35 ` Jeff Garzik
2013-05-02 6:37 ` Anthony Foiani
2013-05-08 12:04 ` Anthony Foiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gppt4gel1.fsf@dworkin.scrye.com \
--to=tkil@scrye$(echo .)com \
--cc=Shaohui.Xie@freescale$(echo .)com \
--cc=bunk@stusta$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=r58472@freescale$(echo .)com \
--cc=rpjday@crashcourse$(echo .)ca \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox