From: "Masayuki Ohtake" <masa-korg@dsn•okisemi.com>
To: "FUJITA Tomonori" <fujita.tomonori@lab•ntt.co.jp>
Cc: <fujita.tomonori@lab•ntt.co.jp>, <shemminger@vyatta•com>,
<sam@ravnborg•org>, <joe@perches•com>,
<linux-kernel@vger•kernel.org>, <netdev@vger•kernel.org>,
<gregory.v.rose@intel•com>, <mbizon@freebox•fr>,
<kristoffer@gaisler•com>, <ralf@linux-mips•org>,
<john.linn@xilinx•com>, <randy.dunlap@oracle•com>,
<davem@davemloft•net>, <meego-dev@meego•com>, <qi.wang@intel•com>,
<yong.y.wang@intel•com>, <andrew.chih.howe.khor@intel•com>,
<joel.clark@intel•com>, <margie.foster@intel•com>,
<okada533@dsn•okisemi.com>, <morinaga526@dsn•okisemi.com>,
<shimizu394@dsn•okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
Date: Tue, 7 Sep 2010 13:06:15 +0900 [thread overview]
Message-ID: <000401cb4e42$0c7b5b10$66f8800a@maildom.okisemi.com> (raw)
In-Reply-To: 20100907122012O.fujita.tomonori@lab.ntt.co.jp
Hi Fujita
> > This DMA of device is not standard. Personal use of Gigabit Ethernet device.
> > So, I guess that I do not need to use DMA-API.
>
> Sorry, I'm not sure what you mean. If a driver does DMA, it must use
> the DMA API. Your driver already uses the DMA API (pci_dma_*),
> however, pci_map_* API is obsolete so please use dma_map_* API
> instead.
Thank you for the explanation.
I understood and use dma_map_* .
Thanks Ohtake
----- Original Message -----
From: "FUJITA Tomonori" <fujita.tomonori@lab•ntt.co.jp>
To: <masa-korg@dsn•okisemi.com>
Cc: <fujita.tomonori@lab•ntt.co.jp>; <shemminger@vyatta•com>; <sam@ravnborg•org>; <joe@perches•com>;
<linux-kernel@vger•kernel.org>; <netdev@vger•kernel.org>; <gregory.v.rose@intel•com>; <mbizon@freebox•fr>;
<kristoffer@gaisler•com>; <ralf@linux-mips•org>; <john.linn@xilinx•com>; <randy.dunlap@oracle•com>;
<davem@davemloft•net>; <meego-dev@meego•com>; <qi.wang@intel•com>; <yong.y.wang@intel•com>;
<andrew.chih.howe.khor@intel•com>; <joel.clark@intel•com>; <margie.foster@intel•com>; <okada533@dsn•okisemi.com>;
<morinaga526@dsn•okisemi.com>; <shimizu394@dsn•okisemi.com>
Sent: Tuesday, September 07, 2010 12:21 PM
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
> On Tue, 7 Sep 2010 10:13:22 +0900
> "Masayuki Ohtake" <masa-korg@dsn•okisemi.com> wrote:
>
> > > Probably, this trick doesn't work because zero could be a valid DMA
> > > address on some architctures.
> > >
> >
> > The flag which shows mapped will be added.
> > And it is used instead of "if (buffer_info->dma) ".
>
> Sounds fine. That's what other drivers do.
>
>
> > > > + /*-- Set Buffer infomation --*/
> > > > + buffer_info->length = skb->len;
> > > > + buffer_info->dma =
> > > > + pci_map_single(adapter->pdev, skb->data, buffer_info->length,
> > > > + PCI_DMA_TODEVICE);
> > >
> > > Needs to handle mapping failure (dma_mapping_errro)?
> >
> > Error process will be added.
>
> Nice.
>
>
> > > Can you use dma_map_* API instead of pci_map_*? Please read:
> > >
> >
> > This DMA of device is not standard. Personal use of Gigabit Ethernet device.
> > So, I guess that I do not need to use DMA-API.
>
> Sorry, I'm not sure what you mean. If a driver does DMA, it must use
> the DMA API. Your driver already uses the DMA API (pci_dma_*),
> however, pci_map_* API is obsolete so please use dma_map_* API
> instead.
>
> Thanks,
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-09-07 4:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 9:56 [PATCH] Gigabit Ethernet driver of Topcliff PCH Masayuki Ohtake
2010-08-26 10:28 ` Sam Ravnborg
2010-08-26 12:47 ` Masayuki Ohtake
2010-08-26 14:44 ` Joe Perches
2010-08-26 15:34 ` Stephen Hemminger
2010-08-26 15:40 ` Stephen Hemminger
2010-08-26 15:41 ` Stephen Hemminger
2010-08-26 15:42 ` Stephen Hemminger
2010-08-26 15:43 ` Stephen Hemminger
2010-08-26 15:45 ` Stephen Hemminger
2010-08-26 15:47 ` Stephen Hemminger
2010-08-26 15:57 ` Stephen Hemminger
2010-08-26 16:05 ` Stephen Hemminger
2010-08-26 16:16 ` Joe Perches
2010-08-26 16:29 ` Stephen Hemminger
2010-08-26 17:02 ` Joe Perches
2010-08-31 14:15 ` Masayuki Ohtake
2010-08-31 14:51 ` Eric Dumazet
2010-09-02 12:39 ` Masayuki Ohtake
2010-09-02 13:40 ` Eric Dumazet
2010-09-02 15:10 ` Stephen Hemminger
2010-09-03 13:32 ` Masayuki Ohtake
2010-09-03 13:43 ` Eric Dumazet
2010-09-03 14:11 ` Masayuki Ohtake
2010-08-31 15:08 ` Randy Dunlap
2010-08-31 16:10 ` Joe Perches
2010-08-31 17:25 ` [PATCH] drivers/net/pch_gbe: Use bool not unsigned char Joe Perches
2010-08-31 18:38 ` [PATCH] drivers/net/pch_gbe: Cleanup stats use Joe Perches
2010-09-01 1:33 ` Stephen Hemminger
2010-09-01 1:38 ` Joe Perches
2010-09-03 2:23 ` [PATCH] Gigabit Ethernet driver of Topcliff PCH FUJITA Tomonori
2010-09-07 1:13 ` Masayuki Ohtake
2010-09-07 3:21 ` FUJITA Tomonori
2010-09-07 4:06 ` Masayuki Ohtake [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 14:09 Masayuki Ohtake
2010-09-03 16:35 ` Jiri Slaby
2010-09-07 1:13 ` Masayuki Ohtake
2010-09-08 13:52 ` Masayuki Ohtake
2010-09-08 14:16 ` Jiri Slaby
2010-09-08 14:54 ` Stephen Hemminger
2010-09-08 14:55 ` Stephen Hemminger
2010-09-09 13:37 ` Masayuki Ohtake
2010-09-09 13:38 ` Masayuki Ohtake
2010-09-03 20:00 ` Joe Perches
2010-09-07 2:42 ` Masayuki Ohtake
2010-09-08 20:36 ` David Miller
2010-09-15 12:19 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401cb4e42$0c7b5b10$66f8800a@maildom.okisemi.com' \
--to=masa-korg@dsn$(echo .)okisemi.com \
--cc=andrew.chih.howe.khor@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=joel.clark@intel$(echo .)com \
--cc=john.linn@xilinx$(echo .)com \
--cc=kristoffer@gaisler$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=margie.foster@intel$(echo .)com \
--cc=mbizon@freebox$(echo .)fr \
--cc=meego-dev@meego$(echo .)com \
--cc=morinaga526@dsn$(echo .)okisemi.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=okada533@dsn$(echo .)okisemi.com \
--cc=qi.wang@intel$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=shemminger@vyatta$(echo .)com \
--cc=shimizu394@dsn$(echo .)okisemi.com \
--cc=yong.y.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox