From: Stephen Hemminger <shemminger@vyatta•com>
To: Joe Perches <joe@perches•com>
Cc: Masayuki Ohtake <masa-korg@dsn•okisemi.com>,
Sam Ravnborg <sam@ravnborg•org>,
LKML <linux-kernel@vger•kernel.org>,
ML netdev <netdev@vger•kernel.org>,
Greg Rose <gregory.v.rose@intel•com>,
Maxime Bizon <mbizon@freebox•fr>,
Kristoffer Glembo <kristoffer@gaisler•com>,
Ralf Baechle <ralf@linux-mips•org>,
John Linn <john.linn@xilinx•com>,
Randy Dunlap <randy.dunlap@oracle•com>,
"David S. Miller" <davem@davemloft•net>,
MeeGo <meego-dev@meego•com>, "Wang, Qi" <qi.wang@intel•com>,
"Wang, Yong Y" <yong.y.wang@intel•com>,
Andrew <andrew.chih.howe.khor@intel•com>,
Intel OTC <joel.clark@intel•com>,
"Foster, Margie" <margie.foster@intel•com>,
Toshiharu Okada <okada533@dsn•okisemi.com>,
Tomoya Morinaga <morinaga526@dsn•okisemi.com>,
Takahiro Shimizu <shimizu394@dsn•okisemi.com>
Subject: Re: [PATCH] drivers/net/pch_gbe: Cleanup stats use
Date: Tue, 31 Aug 2010 18:33:31 -0700 [thread overview]
Message-ID: <20100831183331.5a6aa508@nehalam> (raw)
In-Reply-To: <1283279915.1797.66.camel@Joe-Laptop>
On Tue, 31 Aug 2010 11:38:35 -0700
Joe Perches <joe@perches•com> wrote:
> struct pch_gbe_stats {
> - signed char stat_string[ETH_GSTRING_LEN];
> - int sizeof_stat;
> - int stat_offset;
> + signed char string[ETH_GSTRING_LEN];
> + size_t size;
> + size_t offset;
> };
Is this driver really using 'signed char' here?
Should just be 'char' for a simple string.
next prev parent reply other threads:[~2010-09-01 1:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 9:56 [PATCH] Gigabit Ethernet driver of Topcliff PCH Masayuki Ohtake
2010-08-26 10:28 ` Sam Ravnborg
2010-08-26 12:47 ` Masayuki Ohtake
2010-08-26 14:44 ` Joe Perches
2010-08-26 15:34 ` Stephen Hemminger
2010-08-26 15:40 ` Stephen Hemminger
2010-08-26 15:41 ` Stephen Hemminger
2010-08-26 15:42 ` Stephen Hemminger
2010-08-26 15:43 ` Stephen Hemminger
2010-08-26 15:45 ` Stephen Hemminger
2010-08-26 15:47 ` Stephen Hemminger
2010-08-26 15:57 ` Stephen Hemminger
2010-08-26 16:05 ` Stephen Hemminger
2010-08-26 16:16 ` Joe Perches
2010-08-26 16:29 ` Stephen Hemminger
2010-08-26 17:02 ` Joe Perches
2010-08-31 14:15 ` Masayuki Ohtake
2010-08-31 14:51 ` Eric Dumazet
2010-09-02 12:39 ` Masayuki Ohtake
2010-09-02 13:40 ` Eric Dumazet
2010-09-02 15:10 ` Stephen Hemminger
2010-09-03 13:32 ` Masayuki Ohtake
2010-09-03 13:43 ` Eric Dumazet
2010-09-03 14:11 ` Masayuki Ohtake
2010-08-31 15:08 ` Randy Dunlap
2010-08-31 16:10 ` Joe Perches
2010-08-31 17:25 ` [PATCH] drivers/net/pch_gbe: Use bool not unsigned char Joe Perches
2010-08-31 18:38 ` [PATCH] drivers/net/pch_gbe: Cleanup stats use Joe Perches
2010-09-01 1:33 ` Stephen Hemminger [this message]
2010-09-01 1:38 ` Joe Perches
2010-09-03 2:23 ` [PATCH] Gigabit Ethernet driver of Topcliff PCH FUJITA Tomonori
2010-09-07 1:13 ` Masayuki Ohtake
2010-09-07 3:21 ` FUJITA Tomonori
2010-09-07 4:06 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831183331.5a6aa508@nehalam \
--to=shemminger@vyatta$(echo .)com \
--cc=andrew.chih.howe.khor@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=joel.clark@intel$(echo .)com \
--cc=john.linn@xilinx$(echo .)com \
--cc=kristoffer@gaisler$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=margie.foster@intel$(echo .)com \
--cc=masa-korg@dsn$(echo .)okisemi.com \
--cc=mbizon@freebox$(echo .)fr \
--cc=meego-dev@meego$(echo .)com \
--cc=morinaga526@dsn$(echo .)okisemi.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=okada533@dsn$(echo .)okisemi.com \
--cc=qi.wang@intel$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=shimizu394@dsn$(echo .)okisemi.com \
--cc=yong.y.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox