From: "Swathi K S" <swathi.ks@samsung•com>
To: "'Andrew Lunn'" <andrew@lunn•ch>
Cc: <krzk@kernel•org>, <robh@kernel•org>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<conor+dt@kernel•org>, <richardcochran@gmail•com>,
<mcoquelin.stm32@gmail•com>, <alim.akhtar@samsung•com>,
<linux-fsd@tesla•com>, <netdev@vger•kernel.org>,
<devicetree@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<linux-stm32@st-md-mailman•stormreply.com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-samsung-soc@vger•kernel.org>,
<alexandre.torgue@foss•st.com>, <peppe.cavallaro@st•com>,
<joabreu@synopsys•com>, <rcsekar@samsung•com>,
<ssiddha@tesla•com>, <jayati.sahu@samsung•com>,
<pankaj.dubey@samsung•com>, <ravi.patel@samsung•com>,
<gost.dev@samsung•com>
Subject: RE: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
Date: Wed, 31 Jul 2024 10:08:38 +0530 [thread overview]
Message-ID: <00b201dae303$85f58c80$91e0a580$@samsung.com> (raw)
In-Reply-To: <18b83c34-c0e4-466c-aaa1-fff38c507e9a@lunn.ch>
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn•ch>
> Sent: 31 July 2024 01:44
> To: Swathi K S <swathi.ks@samsung•com>
> Cc: krzk@kernel•org; robh@kernel•org; davem@davemloft•net;
> edumazet@google•com; kuba@kernel•org; pabeni@redhat•com;
> conor+dt@kernel•org; richardcochran@gmail•com;
> mcoquelin.stm32@gmail•com; alim.akhtar@samsung•com; linux-
> fsd@tesla•com; netdev@vger•kernel.org; devicetree@vger•kernel.org; linux-
> kernel@vger•kernel.org; linux-stm32@st-md-mailman•stormreply.com; linux-
> arm-kernel@lists•infradead.org; linux-samsung-soc@vger•kernel.org;
> alexandre.torgue@foss•st.com; peppe.cavallaro@st•com;
> joabreu@synopsys•com; rcsekar@samsung•com; ssiddha@tesla•com;
> jayati.sahu@samsung•com; pankaj.dubey@samsung•com;
> ravi.patel@samsung•com; gost.dev@samsung•com
> Subject: Re: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
>
> > +static int dwc_eqos_rxmux_setup(void *priv, bool external) {
> > + int i = 0;
> > + struct fsd_eqos_plat_data *plat = priv;
> > + struct clk *rx1 = NULL;
> > + struct clk *rx2 = NULL;
> > + struct clk *rx3 = NULL;
>
> Reverse Christmas tree please.
Thanks for review.
We will take care in next patch version after waiting for other review
comments.
>
> > @@ -264,6 +264,7 @@ struct plat_stmmacenet_data {
> > void (*ptp_clk_freq_config)(struct stmmac_priv *priv);
> > int (*init)(struct platform_device *pdev, void *priv);
> > void (*exit)(struct platform_device *pdev, void *priv);
> > + int (*rxmux_setup)(void *priv, bool external);
> > struct mac_device_info *(*setup)(void *priv);
> > int (*clks_config)(void *priv, bool enabled);
> > int (*crosststamp)(ktime_t *device, struct system_counterval_t
> > *system,
>
> It would be good if one of the stmmas Maintainers looked at this. There
are
> already a lot of function pointers here, we should not be added another
one if
> one of the exiting ones could be used.
>
> Andrew
>
> ---
> pw-bot: cr
next prev parent reply other threads:[~2024-07-31 4:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240730092847epcas5p1338397b0ec01a4f0c8387704fb390a40@epcas5p1.samsung.com>
2024-07-30 9:16 ` [PATCH v4 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2024-07-30 9:16 ` [PATCH v4 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Swathi K S
2024-08-06 14:57 ` Rob Herring
2024-07-30 9:16 ` [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2024-07-30 20:14 ` Andrew Lunn
2024-07-31 4:38 ` Swathi K S [this message]
2024-08-01 19:09 ` Serge Semin
2025-01-27 9:45 ` Swathi K S
2024-07-30 9:16 ` [PATCH v4 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Swathi K S
2024-07-30 20:16 ` Andrew Lunn
2024-07-31 4:40 ` Swathi K S
2024-08-01 0:17 ` Andrew Lunn
2024-08-01 3:22 ` Swathi K S
2024-07-30 9:16 ` [PATCH v4 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
2024-07-30 20:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b201dae303$85f58c80$91e0a580$@samsung.com' \
--to=swathi.ks@samsung$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=gost.dev@samsung$(echo .)com \
--cc=jayati.sahu@samsung$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsd@tesla$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pankaj.dubey@samsung$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=ravi.patel@samsung$(echo .)com \
--cc=rcsekar@samsung$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=ssiddha@tesla$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox