From: "Swathi K S" <swathi.ks@samsung•com>
To: "'Andrew Lunn'" <andrew@lunn•ch>
Cc: <krzk@kernel•org>, <robh@kernel•org>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<conor+dt@kernel•org>, <richardcochran@gmail•com>,
<mcoquelin.stm32@gmail•com>, <alim.akhtar@samsung•com>,
<linux-fsd@tesla•com>, <netdev@vger•kernel.org>,
<devicetree@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<linux-stm32@st-md-mailman•stormreply.com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-samsung-soc@vger•kernel.org>,
<alexandre.torgue@foss•st.com>, <peppe.cavallaro@st•com>,
<joabreu@synopsys•com>, <rcsekar@samsung•com>,
<ssiddha@tesla•com>, <jayati.sahu@samsung•com>,
<pankaj.dubey@samsung•com>, <ravi.patel@samsung•com>,
<gost.dev@samsung•com>
Subject: RE: [PATCH v4 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC
Date: Thu, 1 Aug 2024 08:52:35 +0530 [thread overview]
Message-ID: <011701dae3c2$10c864e0$32592ea0$@samsung.com> (raw)
In-Reply-To: <62872c29-0032-4ad8-b771-d57469950c75@lunn.ch>
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn•ch>
> Sent: 01 August 2024 05:48
> To: Swathi K S <swathi.ks@samsung•com>
> Cc: krzk@kernel•org; robh@kernel•org; davem@davemloft•net;
> edumazet@google•com; kuba@kernel•org; pabeni@redhat•com;
> conor+dt@kernel•org; richardcochran@gmail•com;
> mcoquelin.stm32@gmail•com; alim.akhtar@samsung•com; linux-
> fsd@tesla•com; netdev@vger•kernel.org; devicetree@vger•kernel.org; linux-
> kernel@vger•kernel.org; linux-stm32@st-md-mailman•stormreply.com; linux-
> arm-kernel@lists•infradead.org; linux-samsung-soc@vger•kernel.org;
> alexandre.torgue@foss•st.com; peppe.cavallaro@st•com;
> joabreu@synopsys•com; rcsekar@samsung•com; ssiddha@tesla•com;
> jayati.sahu@samsung•com; pankaj.dubey@samsung•com;
> ravi.patel@samsung•com; gost.dev@samsung•com
> Subject: Re: [PATCH v4 3/4] arm64: dts: fsd: Add Ethernet support for
FSYS0
> Block of FSD SoC
>
> > > What is the interface connected to? A switch?
> >
> > Hi Andrew,
> > Thanks for the quick review. AFAIK, this has been discussed earlier. I
> > am providing the links to the same here for quick reference.
> >
> > [1]
> > https://protect2.fireeye.com/v1/url?k=137f9a1c-72027264-137e1153-74fe4
> > 85fffb1-6e7bf5aa53b8cc75&q=1&e=46ff39bb-87c6-4b24-9cee-
> a6ed900a5b7f&u=
> > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F7%2F29%2F419
> > [2]
> > https://protect2.fireeye.com/v1/url?k=dca2820d-bddf6a75-dca30942-74fe4
> > 85fffb1-9b7f4695da0bf0b8&q=1&e=46ff39bb-87c6-4b24-9cee-
> a6ed900a5b7f&u=
> > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F6%2F6%2F817
> > [3]
> > https://protect2.fireeye.com/v1/url?k=552d5dcd-3450b5b5-552cd682-74fe4
> > 85fffb1-3bb7c6c469af30f5&q=1&e=46ff39bb-87c6-4b24-9cee-
> a6ed900a5b7f&u=
> > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F6%2F6%2F507
> > [4]
> > https://protect2.fireeye.com/v1/url?k=c613c4f6-a76e2c8e-c6124fb9-74fe4
> > 85fffb1-469219b2dcdd3e0e&q=1&e=46ff39bb-87c6-4b24-9cee-
> a6ed900a5b7f&u=
> > https%3A%2F%2Flkml.org%2Flkml%2F2023%2F8%2F14%2F1341
> >
> > Please let us know if you have any further queries on this.
>
> Ah, O.K.
>
> It would make sense to add to the commit message something like:
>
> The Ethernet interface is connected to a switch, which Linux is not
managing.
Thanks for the suggestion and it makes sense. Will update the commit
message this way in the next version.
>
> Part of the purpose of the commit message is to answer questions reviewers
> might have. This is one such question.
>
> Andrew
Regards,
Swathi
next prev parent reply other threads:[~2024-08-01 4:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240730092847epcas5p1338397b0ec01a4f0c8387704fb390a40@epcas5p1.samsung.com>
2024-07-30 9:16 ` [PATCH v4 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2024-07-30 9:16 ` [PATCH v4 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Swathi K S
2024-08-06 14:57 ` Rob Herring
2024-07-30 9:16 ` [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2024-07-30 20:14 ` Andrew Lunn
2024-07-31 4:38 ` Swathi K S
2024-08-01 19:09 ` Serge Semin
2025-01-27 9:45 ` Swathi K S
2024-07-30 9:16 ` [PATCH v4 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Swathi K S
2024-07-30 20:16 ` Andrew Lunn
2024-07-31 4:40 ` Swathi K S
2024-08-01 0:17 ` Andrew Lunn
2024-08-01 3:22 ` Swathi K S [this message]
2024-07-30 9:16 ` [PATCH v4 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
2024-07-30 20:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011701dae3c2$10c864e0$32592ea0$@samsung.com' \
--to=swathi.ks@samsung$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=gost.dev@samsung$(echo .)com \
--cc=jayati.sahu@samsung$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsd@tesla$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pankaj.dubey@samsung$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=ravi.patel@samsung$(echo .)com \
--cc=rcsekar@samsung$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=ssiddha@tesla$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox