From: Joe Perches <joe@perches•com>
To: Stephen Hemminger <shemminger@linux-foundation•org>,
Andy Whitcroft <apw@shadowen•org>,
Randy Dunlap <rdunlap@xenotime•net>,
Joel Schopp <jschopp@austin•ibm.com>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
netdev@vger•kernel.org, linux-net-drivers@solarflare•com
Subject: Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller
Date: Tue, 27 Nov 2007 22:47:54 -0800 [thread overview]
Message-ID: <1196232474.31590.75.camel@localhost> (raw)
In-Reply-To: <20071127220954.4f075056@freepuppy.rosehill>
On Tue, 2007-11-27 at 22:09 -0800, Stephen Hemminger wrote:
> ERROR: Macros with multiple statements should be enclosed in a do - while loop
> #21846: FILE: drivers/net/sfc/net_driver.h:1096:
> + for (_channel = &_efx->channel[0]; \
> + _channel < &_efx->channel[EFX_MAX_CHANNELS]; \
> + _channel++) \
This should probably be a WARNING in checkpatch.
Any list_for_each style macro fails this test.
next prev parent reply other threads:[~2007-11-28 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 17:08 [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller Ben Hutchings
2007-11-28 6:09 ` Stephen Hemminger
2007-11-28 6:47 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-29 16:27 Robert Stonehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196232474.31590.75.camel@localhost \
--to=joe@perches$(echo .)com \
--cc=apw@shadowen$(echo .)org \
--cc=bhutchings@solarflare$(echo .)com \
--cc=jschopp@austin$(echo .)ibm.com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox