From: Matt Mackall <mpm@selenic•com>
To: David Miller <davem@davemloft•net>
Cc: danborkmann@googlemail•com, linux-kernel@vger•kernel.org,
jmoyer@redhat•com, netdev@vger•kernel.org, netdev@oss•sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
Date: Mon, 11 Jan 2010 18:03:45 -0600 [thread overview]
Message-ID: <1263254625.29868.4777.camel@calx> (raw)
In-Reply-To: <20100111.155912.68138954.davem@davemloft.net>
On Mon, 2010-01-11 at 15:59 -0800, David Miller wrote:
> From: Matt Mackall <mpm@selenic•com>
> Date: Mon, 11 Jan 2010 17:21:48 -0600
>
> > Looks pretty good. Dave?
> >
> > Acked-by: Matt Mackall <mpm@selenic•com>
>
> I don't like the loop for RX ARP processing.
>
> The packet contents aren't going to change, so doing basic
> packet validation inside of the "for each RX client" loop
> of arp_reply() doesn't make any sense.
True. Dan, please help our poor compilers with some manual loop
invariant motion.
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2010-01-12 0:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:54 [PATCH] netpoll: allow execution of multiple rx_hooks per interface Daniel Borkmann
2010-01-07 3:54 ` Matt Mackall
2010-01-07 9:02 ` David Miller
2010-01-07 19:06 ` Daniel Borkmann
2010-01-08 0:20 ` Daniel Borkmann
2010-01-11 23:21 ` Matt Mackall
2010-01-11 23:59 ` David Miller
2010-01-12 0:03 ` Matt Mackall [this message]
2010-01-12 0:09 ` Daniel Borkmann
2010-01-13 0:27 ` Daniel Borkmann
2010-01-13 13:57 ` Jeff Moyer
2010-01-13 16:53 ` Daniel Borkmann
2010-01-14 4:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263254625.29868.4777.camel@calx \
--to=mpm@selenic$(echo .)com \
--cc=danborkmann@googlemail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmoyer@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@oss$(echo .)sgi.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox