From: Ben Hutchings <bhutchings@solarflare•com>
To: sclark46@earthlink•net
Cc: Marcel Holtmann <marcel@holtmann•org>,
Elina Pasheva <epasheva@sierrawireless•com>,
David Brownell <dbrownell@users•sourceforge.net>,
Rory Filer <rfiler@sierrawireless•com>,
netdev@vger•kernel.org, linux-usb <linux-usb@vger•kernel.org>
Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver
Date: Mon, 29 Mar 2010 01:44:02 +0100 [thread overview]
Message-ID: <1269823442.8653.261.camel@localhost> (raw)
In-Reply-To: <4BAFAA2C.8060604@earthlink.net>
On Sun, 2010-03-28 at 15:12 -0400, Stephen Clark wrote:
> On 03/28/2010 11:57 AM, Marcel Holtmann wrote:
> > Hi Elina,
> >
> >> +static const struct driver_info sierra_net_info_68A3 = {
> >> + .description = "Sierra Wireless USB-Ethernet Modem",
> >> + .flags = FLAG_ETHER | FLAG_SEND_ZLP,
> >> + .bind = sierra_net_bind,
> >> + .unbind = sierra_net_unbind,
> >> + .status = sierra_net_status,
> >> + .rx_fixup = sierra_net_rx_fixup,
> >> + .tx_fixup = sierra_net_tx_fixup,
> >> + .data = (unsigned long)&sierra_net_info_data_68A3,
> >> +};
> >
> > the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these
> > interfaces.
> >
> > Otherwise we have wrong DEVTYPE uevent assignments and userspace will
> > treat them as real Ethernet cards. And that should not happen. As a nice
> Why shouldn't that happen if they look like NIC cards?
[...]
This information is important for management interfaces. The user
doesn't care what your device looks like at the kernel level - they know
it's a wireless broadband device and they expect to see a device
labelled as such in Network Manager or whatever they use.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-03-29 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 1:21 [ANNOUNCEMENT] NET: usb: sierra_net.c driver Elina Pasheva
2010-03-28 10:38 ` Sergei Shtylyov
2010-03-28 15:57 ` Marcel Holtmann
[not found] ` <1269791821.11714.202.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-28 19:12 ` Stephen Clark
2010-03-29 0:44 ` Ben Hutchings [this message]
2010-03-29 12:30 ` Stephen Clark
[not found] ` <4BB09D75.7020500-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 13:07 ` Ben Hutchings
[not found] ` <4BAFAA2C.8060604-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 20:29 ` Marcel Holtmann
2010-03-29 20:41 ` David Miller
[not found] ` <20100329.134144.57458224.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-29 21:18 ` Elina Pasheva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269823442.8653.261.camel@localhost \
--to=bhutchings@solarflare$(echo .)com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=epasheva@sierrawireless$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=marcel@holtmann$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rfiler@sierrawireless$(echo .)com \
--cc=sclark46@earthlink$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox