From: Stephen Clark <sclark46-ihVZJaRskl1bRRN4PJnoQQ@public•gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public•gmane.org>
Cc: Elina Pasheva
<epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public•gmane.org>,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public•gmane.org>,
Rory Filer
<rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver
Date: Sun, 28 Mar 2010 15:12:44 -0400 [thread overview]
Message-ID: <4BAFAA2C.8060604@earthlink.net> (raw)
In-Reply-To: <1269791821.11714.202.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On 03/28/2010 11:57 AM, Marcel Holtmann wrote:
> Hi Elina,
>
>> +static const struct driver_info sierra_net_info_68A3 = {
>> + .description = "Sierra Wireless USB-Ethernet Modem",
>> + .flags = FLAG_ETHER | FLAG_SEND_ZLP,
>> + .bind = sierra_net_bind,
>> + .unbind = sierra_net_unbind,
>> + .status = sierra_net_status,
>> + .rx_fixup = sierra_net_rx_fixup,
>> + .tx_fixup = sierra_net_tx_fixup,
>> + .data = (unsigned long)&sierra_net_info_data_68A3,
>> +};
>
> the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these
> interfaces.
>
> Otherwise we have wrong DEVTYPE uevent assignments and userspace will
> treat them as real Ethernet cards. And that should not happen. As a nice
Why shouldn't that happen if they look like NIC cards?
> benefit the interface name will be wwan%d by default as well.
>
> Regards
>
> Marcel
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety." (Ben Franklin)
"The course of history shows that as a government grows, liberty
decreases." (Thomas Jefferson)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-28 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 1:21 [ANNOUNCEMENT] NET: usb: sierra_net.c driver Elina Pasheva
2010-03-28 10:38 ` Sergei Shtylyov
2010-03-28 15:57 ` Marcel Holtmann
[not found] ` <1269791821.11714.202.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-28 19:12 ` Stephen Clark [this message]
2010-03-29 0:44 ` Ben Hutchings
2010-03-29 12:30 ` Stephen Clark
[not found] ` <4BB09D75.7020500-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 13:07 ` Ben Hutchings
[not found] ` <4BAFAA2C.8060604-ihVZJaRskl1bRRN4PJnoQQ@public.gmane.org>
2010-03-29 20:29 ` Marcel Holtmann
2010-03-29 20:41 ` David Miller
[not found] ` <20100329.134144.57458224.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-29 21:18 ` Elina Pasheva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAFAA2C.8060604@earthlink.net \
--to=sclark46-ihvzjarskl1brrn4pjnoqq@public$(echo .)gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public$(echo .)gmane.org \
--cc=epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox