From: KOVACS Krisztian <hidden@balabit•hu>
To: Jan Engelhardt <jengelh@medozas•de>
Cc: netdev@vger•kernel.org, netfilter-devel@vger•kernel.org,
Patrick McHardy <kaber@trash•net>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH 7/9] tproxy: added IPv6 support to the TPROXY target
Date: Thu, 21 Oct 2010 11:33:24 +0200 [thread overview]
Message-ID: <1287653604.13326.8.camel@este.odu> (raw)
In-Reply-To: <alpine.LNX.2.01.1010211113020.22922@obet.zrqbmnf.qr>
Hi,
On Thu, 2010-10-21 at 11:14 +0200, Jan Engelhardt wrote:
> On Thursday 2010-10-21 10:50, KOVACS Krisztian wrote:
>
> >Hi,
> >
> >On Thu, 2010-10-21 at 10:47 +0200, Jan Engelhardt wrote:
> >> On Wednesday 2010-10-20 13:21, KOVACS Krisztian wrote:
> >> >
> >> > /* TPROXY target is capable of marking the packet to perform
> >> > * redirection. We can get rid of that whenever we get support for
> >> > * mutliple targets in the same rule. */
> >> >-struct xt_tproxy_target_info {
> >> >+struct xt_tproxy_target_info_v0 {
> >> > u_int32_t mark_mask;
> >> > u_int32_t mark_value;
> >> > __be32 laddr;
> >> > __be16 lport;
> >> > };
> >>
> >> You cannot change the struct name either, or it may break userspace
> >> compilations.
> >
> >True, though iptables has its own copy of the header anyway.
>
> There is - or so I always hear - other userspace programs.
>
> As for iptables, we only do the copy so that it compiles independent of
> the kernel version. You have to assume that the headers can be updated
> at any time.
Sure, I wasn't implying we shouldn't fix this in the patch, I just doubt
there's anything else other than iptables using this and iptables itself
isn't affected.
Anyway, I've fixed it. Thanks, Jan.
--KK
next prev parent reply other threads:[~2010-10-21 9:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 11:21 [PATCH 0/9] tproxy: add IPv6 support KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 2/9] tproxy: added const specifiers to udp lookup functions KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 9/9] tproxy: use the interface primary IP address as a default value for --on-ip KOVACS Krisztian
2010-10-21 9:12 ` Jan Engelhardt
2010-10-21 10:32 ` KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 8/9] tproxy: added IPv6 support to the socket match KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 1/9] tproxy: split off ipv6 defragmentation to a separate module KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 6/9] tproxy: added IPv6 socket lookup function to nf_tproxy_core KOVACS Krisztian
2010-10-21 8:42 ` Jan Engelhardt
2010-10-21 9:48 ` KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 7/9] tproxy: added IPv6 support to the TPROXY target KOVACS Krisztian
2010-10-21 8:47 ` Jan Engelhardt
2010-10-21 8:50 ` KOVACS Krisztian
2010-10-21 9:14 ` Jan Engelhardt
2010-10-21 9:33 ` KOVACS Krisztian [this message]
2010-10-20 11:21 ` [PATCH 5/9] tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled KOVACS Krisztian
2010-10-20 12:45 ` YOSHIFUJI Hideaki
2010-10-20 14:07 ` Balazs Scheidler
2010-10-21 21:24 ` YOSHIFUJI Hideaki
2010-10-23 14:48 ` Balazs Scheidler
2010-10-24 5:03 ` YOSHIFUJI Hideaki
2010-10-24 23:08 ` David Miller
2010-10-20 11:21 ` [PATCH 4/9] tproxy: added tproxy sockopt interface in the IPV6 layer KOVACS Krisztian
2010-10-21 8:39 ` Jan Engelhardt
2010-10-21 8:46 ` KOVACS Krisztian
2010-10-21 21:09 ` YOSHIFUJI Hideaki
2010-10-20 11:21 ` [PATCH 3/9] tproxy: added udp6_lib_lookup function KOVACS Krisztian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287653604.13326.8.camel@este.odu \
--to=hidden@balabit$(echo .)hu \
--cc=davem@davemloft$(echo .)net \
--cc=jengelh@medozas$(echo .)de \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox