From: KOVACS Krisztian <hidden@balabit•hu>
To: Jan Engelhardt <jengelh@medozas•de>
Cc: netdev@vger•kernel.org, netfilter-devel@vger•kernel.org,
Patrick McHardy <kaber@trash•net>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH 9/9] tproxy: use the interface primary IP address as a default value for --on-ip
Date: Thu, 21 Oct 2010 12:32:08 +0200 [thread overview]
Message-ID: <1287657128.13326.42.camel@este.odu> (raw)
In-Reply-To: <alpine.LNX.2.01.1010211051560.22922@obet.zrqbmnf.qr>
Hi,
On Thu, 2010-10-21 at 11:12 +0200, Jan Engelhardt wrote:
> On Wednesday 2010-10-20 13:21, KOVACS Krisztian wrote:
> >+
> >+ if (!ipv6_addr_any(user_laddr))
> >+ return user_laddr;
> >+ laddr = NULL;
> >+
> >+ rcu_read_lock();
> >+ indev = __in6_dev_get(skb->dev);
> >+ if (indev)
> >+ list_for_each_entry(ifa, &indev->addr_list, if_list) {
> >+ /* FIXME: address selection */
>
> Per our realworld discussion, I believe we should add checks for
> some conditions (RFC 4862 section 2):
>
> 1. ignore tentative addresses
>
> if (ifa->ifa_flags & IFA_F_TENTATIVE)
> continue;
Yep, we should definitely do that.
> 2. tests for when the interface's ifa->preferred_lft == 0/deprecatedness:
>
> if (ctinfo == IP_CT_NEW/RELATED && (ifa->ifa_flags & IFA_F_DEPRECATED))
> continue;
Well, we can use the TPROXY target without conntrack so we cannot really
check if ctinfo==IP_CT_NEW/RELATED. However, we do address selection
only in case no established socket was found for the skb, so I think
it's safe to ignore addresses with IFA_F_DEPRECATED set.
Something like
if (ifa->ifa_flags & (IFA_F_TENTATIVE | IFA_F_DEPRECATED))
continue;
> 3. check for invalid addresses
> (There might be a flag like tentative..)
>
> if (ifa->valid_lft == 0)
> continue;
I didn't find such a flag and it seems that valid_lft contains the
lifetime in seconds, so I think it's not that simple. The addrconf.c
code does something like this:
unsigned long age = (jiffies - ifp->tstamp) / HZ;
if (age >= ifp->valid_lft) {
/* not valid */
}
The code also sets the deprecated flag when the preferred lifetime
expires and I think valid_lft must be less or equal to prefered_lft. If
this is the case then I think this case should be already covered by
checking for IFA_F_DEPRECATED above.
--KK
next prev parent reply other threads:[~2010-10-21 10:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 11:21 [PATCH 0/9] tproxy: add IPv6 support KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 1/9] tproxy: split off ipv6 defragmentation to a separate module KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 8/9] tproxy: added IPv6 support to the socket match KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 9/9] tproxy: use the interface primary IP address as a default value for --on-ip KOVACS Krisztian
2010-10-21 9:12 ` Jan Engelhardt
2010-10-21 10:32 ` KOVACS Krisztian [this message]
2010-10-20 11:21 ` [PATCH 2/9] tproxy: added const specifiers to udp lookup functions KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 7/9] tproxy: added IPv6 support to the TPROXY target KOVACS Krisztian
2010-10-21 8:47 ` Jan Engelhardt
2010-10-21 8:50 ` KOVACS Krisztian
2010-10-21 9:14 ` Jan Engelhardt
2010-10-21 9:33 ` KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 6/9] tproxy: added IPv6 socket lookup function to nf_tproxy_core KOVACS Krisztian
2010-10-21 8:42 ` Jan Engelhardt
2010-10-21 9:48 ` KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 5/9] tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled KOVACS Krisztian
2010-10-20 12:45 ` YOSHIFUJI Hideaki
2010-10-20 14:07 ` Balazs Scheidler
2010-10-21 21:24 ` YOSHIFUJI Hideaki
2010-10-23 14:48 ` Balazs Scheidler
2010-10-24 5:03 ` YOSHIFUJI Hideaki
2010-10-24 23:08 ` David Miller
2010-10-20 11:21 ` [PATCH 3/9] tproxy: added udp6_lib_lookup function KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 4/9] tproxy: added tproxy sockopt interface in the IPV6 layer KOVACS Krisztian
2010-10-21 8:39 ` Jan Engelhardt
2010-10-21 8:46 ` KOVACS Krisztian
2010-10-21 21:09 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287657128.13326.42.camel@este.odu \
--to=hidden@balabit$(echo .)hu \
--cc=davem@davemloft$(echo .)net \
--cc=jengelh@medozas$(echo .)de \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox