From: Dan Rosenberg <drosenberg@vsecurity•com>
To: David Miller <davem@davemloft•net>
Cc: socketcan@hartkopp•net, kuznet@ms2•inr.ac.ru,
urs.thuermann@volkswagen•de, yoshfuji@linux-ipv6•org,
kaber@trash•net, jmorris@namei•org,
remi.denis-courmont@nokia•com, pekkas@netcore•fi, sri@us•ibm.com,
vladislav.yasevich@hp•com, tj@kernel•org, eric.dumazet@gmail•com,
lizf@cn•fujitsu.com, joe@perches•com, shemminger@vyatta•com,
hadi@mojatatu•com, ebiederm@xmission•com, adobriyan@gmail•com,
jpirko@redhat•com, johannes.berg@intel•com,
daniel.lezcano@free•fr, xemul@openvz•org,
socketcan-core@lists•berlios.de, netdev@vger•kernel.org,
linux-sctp@vger•kernel.org, torvalds@linux-foundation•org
Subject: Re: [PATCH 4/10] Fix leaking of kernel heap addresses in net/
Date: Thu, 11 Nov 2010 21:51:04 -0500 [thread overview]
Message-ID: <1289530264.3090.212.camel@Dan> (raw)
In-Reply-To: <20101111.184902.233699247.davem@davemloft.net>
> >
> >> I want whatever you replace it with to be equivalent for
> >> object tracking purposes.
> >
> > In nearly all of the cases I fixed, the socket inode is already
> > provided, which serves as a perfectly good unique identifier. Would you
> > prefer I include that information twice?
>
> The problem is that the socket inode is not available in a certain
> subclass of cases, so the transformation is not equivalent.
>
> Why not attack this at the heart of where your concern is, and hack
> the %p format handling to do whatever it is you like instead of
> patching code all over the tree?
This has already been suggested, and I agree it is a much better
approach. If I take this approach, and find some suitable substitute
for those cases where the socket inode is not available, will you
consider these changes?
-Dan
next prev parent reply other threads:[~2010-11-12 2:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 2:15 [PATCH 4/10] Fix leaking of kernel heap addresses in net/ Dan Rosenberg
[not found] ` <2129857903-1289528127-cardhu_decombobulator_blackberry.rim.net-1506931048--JnVBb1XAImjjL2gL5RxOEzYg3SYOavFBmZ6FRVpaDsI@public.gmane.org>
2010-11-12 2:29 ` David Miller
2010-11-12 2:34 ` Dan Rosenberg
2010-11-12 2:49 ` David Miller
2010-11-12 2:51 ` Dan Rosenberg [this message]
2010-11-12 2:59 ` David Miller
2010-11-12 7:23 ` Eric Dumazet
2010-11-12 12:37 ` Dan Rosenberg
2010-11-12 16:33 ` Stephen Hemminger
2010-11-12 17:24 ` Dan Rosenberg
2010-11-12 18:33 ` Stephen Hemminger
2010-11-12 20:18 ` Alexey Dobriyan
2010-11-12 20:37 ` David Miller
2010-11-12 22:40 ` Alexey Dobriyan
2010-11-12 22:46 ` David Miller
[not found] <1289673008.3090.350.camel@Dan>
2010-11-13 18:42 ` Dan Rosenberg
-- strict thread matches above, loose matches on Subject: below --
2010-11-12 1:07 Dan Rosenberg
2010-11-12 1:10 ` David Miller
2010-11-12 1:20 ` Dan Rosenberg
2010-11-12 2:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289530264.3090.212.camel@Dan \
--to=drosenberg@vsecurity$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=daniel.lezcano@free$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hadi@mojatatu$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=lizf@cn$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=remi.denis-courmont@nokia$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=socketcan-core@lists$(echo .)berlios.de \
--cc=socketcan@hartkopp$(echo .)net \
--cc=sri@us$(echo .)ibm.com \
--cc=tj@kernel$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=urs.thuermann@volkswagen$(echo .)de \
--cc=vladislav.yasevich@hp$(echo .)com \
--cc=xemul@openvz$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox