From: Alexey Dobriyan <adobriyan@gmail•com>
To: David Miller <davem@davemloft•net>
Cc: shemminger@vyatta•com, netdev@vger•kernel.org
Subject: Re: [PATCH 4/10] Fix leaking of kernel heap addresses in net/
Date: Sat, 13 Nov 2010 00:40:27 +0200 [thread overview]
Message-ID: <20101112224026.GA21134@core2.telecom.by> (raw)
In-Reply-To: <20101112.123738.179940542.davem@davemloft.net>
On Fri, Nov 12, 2010 at 12:37:38PM -0800, David Miller wrote:
> From: Alexey Dobriyan <adobriyan@gmail•com>
> Date: Fri, 12 Nov 2010 22:18:50 +0200
>
> > On Fri, Nov 12, 2010 at 08:33:15AM -0800, Stephen Hemminger wrote:
> >> Also, the whole idea needs to be under a config option, so only
> >> the paranoid idiots turn it on.
> >
> > Would be fun if something will break because ffff8800bcd498c0
> > will become something else. :-)
>
> Actually, this is not even a joke.
>
> Take a look at how we track what sockets a user wants dumped via
> the inet_diag netlink facility, the socket pointer is used as
> the identification cookie.
I think we should not expose kernel pointers in future interfaces,
but leave existing ones alone.
next prev parent reply other threads:[~2010-11-12 22:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 2:15 [PATCH 4/10] Fix leaking of kernel heap addresses in net/ Dan Rosenberg
[not found] ` <2129857903-1289528127-cardhu_decombobulator_blackberry.rim.net-1506931048--JnVBb1XAImjjL2gL5RxOEzYg3SYOavFBmZ6FRVpaDsI@public.gmane.org>
2010-11-12 2:29 ` David Miller
2010-11-12 2:34 ` Dan Rosenberg
2010-11-12 2:49 ` David Miller
2010-11-12 2:51 ` Dan Rosenberg
2010-11-12 2:59 ` David Miller
2010-11-12 7:23 ` Eric Dumazet
2010-11-12 12:37 ` Dan Rosenberg
2010-11-12 16:33 ` Stephen Hemminger
2010-11-12 17:24 ` Dan Rosenberg
2010-11-12 18:33 ` Stephen Hemminger
2010-11-12 20:18 ` Alexey Dobriyan
2010-11-12 20:37 ` David Miller
2010-11-12 22:40 ` Alexey Dobriyan [this message]
2010-11-12 22:46 ` David Miller
[not found] <1289673008.3090.350.camel@Dan>
2010-11-13 18:42 ` Dan Rosenberg
-- strict thread matches above, loose matches on Subject: below --
2010-11-12 1:07 Dan Rosenberg
2010-11-12 1:10 ` David Miller
2010-11-12 1:20 ` Dan Rosenberg
2010-11-12 2:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112224026.GA21134@core2.telecom.by \
--to=adobriyan@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox