From: Ben Hutchings <bhutchings@solarflare•com>
To: Jiri Pirko <jpirko@redhat•com>
Cc: netdev@vger•kernel.org, ralf@linux-mips•org, fubar@us•ibm.com,
andy@greyhouse•net, kaber@trash•net, bprakash@broadcom•com,
JBottomley@parallels•com, robert.w.love@intel•com,
davem@davemloft•net, shemminger@linux-foundation•org,
decot@google•com, mirq-linux@rere•qmqm.pl,
alexander.h.duyck@intel•com, amit.salecha@qlogic•com,
eric.dumazet@gmail•com, therbert@google•com,
paulmck@linux•vnet.ibm.com, laijs@cn•fujitsu.com,
xiaosuo@gmail•com, greearb@candelatech•com,
loke.chetan@gmail•com, linux-mips@linux-mips•org,
linux-scsi@vger•kernel.org, devel@open-fcoe•org,
bridge@lists•linux-foundation.org
Subject: Re: [patch net-next-2.6 v2] net: consolidate and fix ethtool_ops->get_settings calling
Date: Fri, 02 Sep 2011 19:46:01 +0100 [thread overview]
Message-ID: <1314989161.3419.5.camel@bwh-desktop> (raw)
In-Reply-To: <20110902122630.GC1991@minipsycho>
On Fri, 2011-09-02 at 14:26 +0200, Jiri Pirko wrote:
> This patch does several things:
> - introduces __ethtool_get_settings which is called from ethtool code and
> from dev_ethtool_get_settings() as well.
> - dev_ethtool_get_settings() becomes rtnl wrapper for
> __ethtool_get_settings()
[...]
I don't like this locking change. Most other dev_*() functions require
the caller to hold RTNL, and it will break any OOT module calling
dev_ethtool_get_settings() without producing any warning at compile
time. Why not put an ASSERT_RTNL() in it instead?
The rest of this looks fine.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-09-02 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 19:28 [patch net-next-2.6] net: consolidate and fix ethtool_ops->get_settings calling Jiri Pirko
2011-09-02 12:26 ` [patch net-next-2.6 v2] " Jiri Pirko
2011-09-02 18:46 ` Ben Hutchings [this message]
2011-09-02 20:42 ` Jiri Pirko
2011-09-03 13:34 ` [patch net-next-2.6 v3] " Jiri Pirko
2011-09-03 13:46 ` Ben Hutchings
2011-09-06 3:25 ` Zou, Yi
[not found] ` <5A9BD224CEA58D4CB62235967D650C160A1B7D1C-osO9UTpF0UQd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-06 6:52 ` Bhanu Prakash Gollapudi
2011-09-06 12:20 ` Ralf Baechle
2011-09-15 21:33 ` [patch net-next-2.6] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314989161.3419.5.camel@bwh-desktop \
--to=bhutchings@solarflare$(echo .)com \
--cc=JBottomley@parallels$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=amit.salecha@qlogic$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=bprakash@broadcom$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=decot@google$(echo .)com \
--cc=devel@open-fcoe$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=greearb@candelatech$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=laijs@cn$(echo .)fujitsu.com \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=loke.chetan@gmail$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=ralf@linux-mips$(echo .)org \
--cc=robert.w.love@intel$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=therbert@google$(echo .)com \
--cc=xiaosuo@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox