From: "Bhanu Prakash Gollapudi" <bprakash-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
To: "Zou, Yi" <yi.zou-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
Cc: "amit.salecha-h88ZbnxC6KDQT0dZR+AlfA@public•gmane.org"
<amit.salecha-h88ZbnxC6KDQT0dZR+AlfA@public•gmane.org>,
"bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public•gmane.org"
<bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public•gmane.org>,
"linux-mips-6z/3iImG2C8G8FEW9MqTrA@public•gmane.org"
<linux-mips-6z/3iImG2C8G8FEW9MqTrA@public•gmane.org>,
"JBottomley-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org"
<JBottomley-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>,
"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"decot-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org"
<decot-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org>,
"shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org"
<shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>,
"andy-QlMahl40kYEqcZcGjlUOXw@public•gmane.org"
<andy-QlMahl40kYEqcZcGjlUOXw@public•gmane.org>,
"therbert-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org"
<therbert-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org>,
"eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org"
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
"fubar-r/Jw6+rmf7HQT0dZR+AlfA@public•gmane.org"
<fubar-r/Jw6+rmf7HQT0dZR+AlfA@public•gmane.org>,
"xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org"
<xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
"paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public•gmane.org"
<paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public•gmane.org>,
"Duyck,
Alexander H"
<alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
"mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public•gmane.org"
<mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public•gmane.org>,
Ben Hutchings
<bhutchings-s/n/eUQHGBpZroRs9YW3xA@public•gmane.org>,
"greearb-my8/4N5VtI7c+919tysfdA@public•gmane.org"
<greearb-my8/4N5VtI6/mCGcgd5LIw@public•gmane.org
Subject: Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling
Date: Mon, 5 Sep 2011 23:52:22 -0700 [thread overview]
Message-ID: <4E65C326.3010506@broadcom.com> (raw)
In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C-osO9UTpF0UQd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 9/5/2011 8:25 PM, Zou, Yi wrote:
>>
>> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote:
>>> This patch does several things:
>>> - introduces __ethtool_get_settings which is called from ethtool code
>> and
>>> from drivers as well. Put ASSERT_RTNL there.
>>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings()
>>> - changes calling in drivers so rtnl locking is respected. In
>>> iboe_get_rate was previously ->get_settings() called unlocked. This
>>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same
>>> problem. Also fixed by calling __dev_get_by_index() instead of
>>> dev_get_by_index() and holding rtnl_lock for both calls.
>>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
>>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they
>>> are from other places.
>>> - use __ethtool_get_settings() in bonding code
>>>
>>> Signed-off-by: Jiri Pirko<jpirko-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
>> Reviewed-by: Ben Hutchings<bhutchings-s/n/eUQHGBpZroRs9YW3xA@public•gmane.org> [except FCoE bits]
>>
>> Ben.
> FCoE bits look ok to me. Thanks,
>
> Reviewed-by: Yi Zou<yi.zou-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
bnx2fc changes looks OK to me.
Reviewed-by: Bhanu Prakash Gollapudi <bprakash-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
>
>>
>> --
>> Ben Hutchings, Staff Engineer, Solarflare
>> Not speaking for my employer; that's the marketing department's job.
>> They asked us to note that Solarflare product names are trademarked.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-06 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 19:28 [patch net-next-2.6] net: consolidate and fix ethtool_ops->get_settings calling Jiri Pirko
2011-09-02 12:26 ` [patch net-next-2.6 v2] " Jiri Pirko
2011-09-02 18:46 ` Ben Hutchings
2011-09-02 20:42 ` Jiri Pirko
2011-09-03 13:34 ` [patch net-next-2.6 v3] " Jiri Pirko
2011-09-03 13:46 ` Ben Hutchings
2011-09-06 3:25 ` Zou, Yi
[not found] ` <5A9BD224CEA58D4CB62235967D650C160A1B7D1C-osO9UTpF0UQd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-06 6:52 ` Bhanu Prakash Gollapudi [this message]
2011-09-06 12:20 ` Ralf Baechle
2011-09-15 21:33 ` [patch net-next-2.6] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E65C326.3010506@broadcom.com \
--to=bprakash-dy08kvg/lbpwk0htik3j/w@public$(echo .)gmane.org \
--cc=JBottomley-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=amit.salecha-h88ZbnxC6KDQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=andy-QlMahl40kYEqcZcGjlUOXw@public$(echo .)gmane.org \
--cc=bhutchings-s/n/eUQHGBpZroRs9YW3xA@public$(echo .)gmane.org \
--cc=bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public$(echo .)gmane.org \
--cc=decot-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=fubar-r/Jw6+rmf7HQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=greearb-my8/4N5VtI6/mCGcgd5LIw@public$(echo .)gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public$(echo .)gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public$(echo .)gmane.org \
--cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public$(echo .)gmane.org \
--cc=shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=therbert-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=yi.zou-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox