From: "Dmitry Kozlov" <xeb@mail•ru>
To: "Eric W. Biederman" <ebiederm@xmission•com>
Cc: netdev@vger•kernel.org
Subject: Re]: [PATCH net-next v2] GRE over IPv6
Date: Sun, 29 Jul 2012 11:44:43 +0400 [thread overview]
Message-ID: <1343547883.979817750@f216.mail.ru> (raw)
In-Reply-To: <878ve3114x.fsf@xmission.com>
Eric W. Biederman <ebiederm@xmission•com> wrote:
> >
> >> Why are you implementing an ioctl based instead of using netlink?
> >> Last I looked using netlink to create and delete tunnels was more
> >> flexible and the preferred method and the existing ioctl based methods
> >> were simply being maintained for backwards compatibility.
> > I have implemented both ioctl and netlink based.
> > So if ioctl based is unnecessary it is not difficult to remove this
> > part.
> >
> >> Also it appears that you have failed to include the all important
> >> ip6_gre.c
> > What do you mean ?
>
> I mean quit simply your patch adds to the Makefile the line:
> obj-$(CONFIG_IPV6_GRE) += ip6_gre.o
>
> But that your patch does not include a file named ip6_gre.c
> Also your patch description talks about ip6gre_tnl_link_config and
> ip6gre_newlink but those functions do not exist in your patch. I
> presume those functions are implemented in the missing ip6_gre.c
>
> So please read the patch you sent to the mailing list and figure
> out which file or files are missing.
Thank you for your suggestion, I will resend patch...
prev parent reply other threads:[~2012-07-29 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 7:35 [PATCH net-next v2] GRE over IPv6 Dmitry Kozlov
2012-07-28 20:16 ` Eric W. Biederman
2012-07-29 5:31 ` Dmitry Kozlov
2012-07-29 7:23 ` Eric W. Biederman
2012-07-29 7:44 ` Dmitry Kozlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343547883.979817750@f216.mail.ru \
--to=xeb@mail$(echo .)ru \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox