public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: ebiederm@xmission•com (Eric W. Biederman)
To: Dmitry Kozlov <xeb@mail•ru>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next v2] GRE over IPv6
Date: Sun, 29 Jul 2012 00:23:42 -0700	[thread overview]
Message-ID: <878ve3114x.fsf@xmission.com> (raw)
In-Reply-To: <20120729093127.53091c1d@comp1> (Dmitry Kozlov's message of "Sun, 29 Jul 2012 09:31:27 +0400")

Dmitry Kozlov <xeb@mail•ru> writes:

> Eric W. Biederman <ebiederm@xmission•com> wrote:
>
>> Why are you implementing an ioctl based instead of using netlink?
>> Last I looked using netlink to create and delete tunnels was more
>> flexible and the preferred method and the existing ioctl based methods
>> were simply being maintained for backwards compatibility.
> I have implemented both ioctl and netlink based.
> So if ioctl based is unnecessary it is not difficult to remove this
> part.
>
>> Also it appears that you have failed to include the all important
>> ip6_gre.c
> What do you mean ?

I mean quit simply your patch adds to the Makefile the line:
obj-$(CONFIG_IPV6_GRE) += ip6_gre.o

But that your patch does not include a file named ip6_gre.c

Also your patch description talks about ip6gre_tnl_link_config and
ip6gre_newlink but those functions do not exist in your patch.  I
presume those functions are implemented in the missing ip6_gre.c

So please read the patch you sent to the mailing list and figure
out which file or files are missing.

Eric

next prev parent reply	other threads:[~2012-07-29  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28  7:35 [PATCH net-next v2] GRE over IPv6 Dmitry Kozlov
2012-07-28 20:16 ` Eric W. Biederman
2012-07-29  5:31   ` Dmitry Kozlov
2012-07-29  7:23     ` Eric W. Biederman [this message]
2012-07-29  7:44       ` Re]: " Dmitry Kozlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ve3114x.fsf@xmission.com \
    --to=ebiederm@xmission$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=xeb@mail$(echo .)ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox