From: Dan Williams <dcbw@redhat•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: Or Gerlitz <ogerlitz@mellanox•com>,
netdev@vger•kernel.org, amirv@mellanox•com, ronye@mellanox•com
Subject: Re: [PATCH RFC iproute2] Add VF link state control
Date: Wed, 08 May 2013 11:24:46 -0500 [thread overview]
Message-ID: <1368030286.1664.16.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20130508091753.0be79e6c@nehalam.linuxnetplumber.net>
On Wed, 2013-05-08 at 09:17 -0700, Stephen Hemminger wrote:
> On Wed, 8 May 2013 16:45:17 +0300
> Or Gerlitz <ogerlitz@mellanox•com> wrote:
>
> > From: Rony Efraim <ronye@mellanox•com>
> >
> > Add link state per VF command
> >
> > Signed-off-by: Rony Efraim <ronye@mellanox•com>
>
> Isn't this redundant with OPERSTATE and LOWER_DOWN?
I was going to say it was mostly redundant with the "set carrier from
userspace" patches from jpirko last December, but since a VF doesn't
appear to always have a netdev, it seems that functionality has to be
special-cased for VFs instead of being generic :(
Dan
next prev parent reply other threads:[~2013-05-08 16:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:45 [PATCH RFC 0/2] Control VF link state Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 1/2] net/core: Add netlink directives to control " Or Gerlitz
2013-05-08 16:02 ` Sergei Shtylyov
2013-06-09 9:51 ` Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 2/2] net/mlx4: Add vf link state support Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC iproute2] Add VF link state control Or Gerlitz
2013-05-08 16:17 ` Stephen Hemminger
2013-05-08 16:24 ` Dan Williams [this message]
2013-05-08 16:44 ` John Fastabend
2013-05-08 17:31 ` Or Gerlitz
2013-05-09 8:34 ` Or Gerlitz
2013-05-09 15:24 ` [PATCH RFC 0/2] Control VF link state Ben Hutchings
2013-05-09 23:17 ` Or Gerlitz
2013-05-10 0:34 ` Ben Hutchings
2013-05-12 21:48 ` Or Gerlitz
2013-05-14 17:12 ` Ben Hutchings
2013-05-14 19:59 ` John Fastabend
2013-05-20 20:06 ` Or Gerlitz
2013-05-20 20:37 ` Ben Hutchings
2013-05-21 20:12 ` Or Gerlitz
2013-05-21 21:43 ` John Fastabend
2013-06-09 13:27 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368030286.1664.16.camel@dcbw.foobar.com \
--to=dcbw@redhat$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=ronye@mellanox$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox