From: Or Gerlitz <ogerlitz@mellanox•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: <netdev@vger•kernel.org>, <amirv@mellanox•com>, <ronye@mellanox•com>
Subject: Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF link state
Date: Sun, 9 Jun 2013 12:51:15 +0300 [thread overview]
Message-ID: <51B45013.5000708@mellanox.com> (raw)
In-Reply-To: <518A76FB.5030704@cogentembedded.com>
On 08/05/2013 19:02, Sergei Shtylyov wrote:
>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
>> index a08bd2b..bec44a3 100644
>> --- a/net/core/rtnetlink.c
>> +++ b/net/core/rtnetlink.c
>> @@ -1238,6 +1238,15 @@ static int do_setvfinfo(struct net_device
>> *dev, struct nlattr *attr)
>> ivs->setting);
>> break;
>> }
>> + case IFLA_VF_LINK_STATE: {
>> + struct ifla_vf_link_state *ivl;
>> + ivl = nla_data(vf);
>
> Why not make it initializer? And empty line is needed between the
> declaration and other code.
b/c we followed the conventions introduced in the preceding cases of
do_setvfinfo which we found to be OK
next prev parent reply other threads:[~2013-06-09 9:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:45 [PATCH RFC 0/2] Control VF link state Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 1/2] net/core: Add netlink directives to control " Or Gerlitz
2013-05-08 16:02 ` Sergei Shtylyov
2013-06-09 9:51 ` Or Gerlitz [this message]
2013-05-08 13:45 ` [PATCH RFC 2/2] net/mlx4: Add vf link state support Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC iproute2] Add VF link state control Or Gerlitz
2013-05-08 16:17 ` Stephen Hemminger
2013-05-08 16:24 ` Dan Williams
2013-05-08 16:44 ` John Fastabend
2013-05-08 17:31 ` Or Gerlitz
2013-05-09 8:34 ` Or Gerlitz
2013-05-09 15:24 ` [PATCH RFC 0/2] Control VF link state Ben Hutchings
2013-05-09 23:17 ` Or Gerlitz
2013-05-10 0:34 ` Ben Hutchings
2013-05-12 21:48 ` Or Gerlitz
2013-05-14 17:12 ` Ben Hutchings
2013-05-14 19:59 ` John Fastabend
2013-05-20 20:06 ` Or Gerlitz
2013-05-20 20:37 ` Ben Hutchings
2013-05-21 20:12 ` Or Gerlitz
2013-05-21 21:43 ` John Fastabend
2013-06-09 13:27 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B45013.5000708@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronye@mellanox$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox