From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: David Miller <davem@davemloft•net>
Cc: simon.vincent@xsilon•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message
Date: Tue, 07 Oct 2014 22:26:30 +0200 [thread overview]
Message-ID: <1412713590.11600.5.camel@localhost> (raw)
In-Reply-To: <20141007.155545.116517484203308074.davem@davemloft.net>
On Di, 2014-10-07 at 15:55 -0400, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@stressinduktion•org>
> Date: Tue, 07 Oct 2014 01:53:46 +0200
>
> > Might be possible, but I would favor to get rid of the printk or move
> > the test for informational icmp notifications up.
> > Some of the type < 128 icmp (non-informal) packets we also report to
> > user space, so we cannot just add them to a blacklist.
>
> So basically:
>
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index 141e1f3..97ae700 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -777,12 +777,12 @@ static int icmpv6_rcv(struct sk_buff *skb)
> break;
>
> default:
> - LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> -
> /* informational */
> if (type & ICMPV6_INFOMSG_MASK)
> break;
>
> + LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> +
> /*
> * error of unknown type.
> * must pass to upper level
Yep, can you take care of this?
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
Thanks! :)
next prev parent reply other threads:[~2014-10-07 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 10:37 [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message Simon Vincent
2014-10-06 22:13 ` David Miller
2014-10-06 23:53 ` Hannes Frederic Sowa
2014-10-07 19:55 ` David Miller
2014-10-07 20:26 ` Hannes Frederic Sowa [this message]
2014-10-07 20:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412713590.11600.5.camel@localhost \
--to=hannes@stressinduktion$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=simon.vincent@xsilon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox